Bug 231651 - Stop using makeWeakPtr() in WebCore
Summary: Stop using makeWeakPtr() in WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 231580
Blocks:
  Show dependency treegraph
 
Reported: 2021-10-12 17:50 PDT by Chris Dumez
Modified: 2021-10-13 10:01 PDT (History)
45 users (show)

See Also:


Attachments
Patch (220.50 KB, patch)
2021-10-12 18:08 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (220.32 KB, patch)
2021-10-12 19:22 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (219.85 KB, patch)
2021-10-13 07:47 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-10-12 17:50:43 PDT
Stop using makeWeakPtr() in WebCore and use WeakPtr { } directly instead.
Comment 1 Chris Dumez 2021-10-12 18:08:21 PDT
Created attachment 441025 [details]
Patch
Comment 2 Chris Dumez 2021-10-12 19:22:50 PDT
Created attachment 441032 [details]
Patch
Comment 3 Alex Christensen 2021-10-13 07:24:18 PDT
Comment on attachment 441032 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441032&action=review

> Source/WebCore/html/HTMLMediaElement.h:1171
> +    WeakPtr<MediaResourceLoader> m_lastMediaResourceLoaderForTesting;

no more const?
Comment 4 Chris Dumez 2021-10-13 07:30:10 PDT
(In reply to Alex Christensen from comment #3)
> Comment on attachment 441032 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=441032&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.h:1171
> > +    WeakPtr<MediaResourceLoader> m_lastMediaResourceLoaderForTesting;
> 
> no more const?

I'll check if I can keep it.
Comment 5 Chris Dumez 2021-10-13 07:47:14 PDT
Created attachment 441078 [details]
Patch
Comment 6 Chris Dumez 2021-10-13 08:38:03 PDT
Comment on attachment 441078 [details]
Patch

Clearing flags on attachment: 441078

Committed r284093 (242921@main): <https://commits.webkit.org/242921@main>
Comment 7 Chris Dumez 2021-10-13 08:38:10 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2021-10-13 08:39:18 PDT
<rdar://problem/84199640>