Bug 231644 – [css-values-4] viewport units should be floats

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Devin Rousso]

views can be fractional pixels wide

[Radar WebKit Bug Importer]

<rdar://problem/84172685>

[Devin Rousso]

Created attachment 442065 [details]
Patch

[Devin Rousso]

Comment on attachment 442065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442065&action=review

> Source/WebCore/page/FrameView.cpp:-5640
> -    // Use the large size if no override is given since it's considered the default size.
> -    // if (m_largeViewportSizeOverride) {

I accidentally left this in when I was working on fixing EWS test failures for <https://webkit.org/b/219287> 😅

[Tim Horton]

Comment on attachment 442065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442065&action=review

> Source/WebCore/ChangeLog:9
> +        Views can be fractional pixels wide. We should not round, especially since viewport units

>Views can be fractional pixels wide.

Technically true but many other parts of WebKit do not correctly support even fractional *points* let alone fractional pixels. (Though I think you meant points anyway?).

Still, no harm in this change.

[Devin Rousso]

Created attachment 443373 [details]
Patch

[EWS]

Committed r285345 (243906@main): <https://commits.webkit.org/243906@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443373 [details].