Bug 231644 - [css-values-4] viewport units should be floats
Summary: [css-values-4] viewport units should be floats
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 219287
Blocks:
  Show dependency tree / graph
 
Reported: 2021-10-12 16:38 PDT by Devin Rousso
Modified: 2021-11-05 10:43 PDT (History)
11 users (show)

See Also:

Attachments
Patch (32.97 KB, patch)
2021-10-21 14:48 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (33.81 KB, patch)
2021-11-04 20:40 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-10-12 16:38:20 PDT 
views can be fractional pixels wide
Comment 1 Radar WebKit Bug Importer 2021-10-12 16:47:13 PDT 
<rdar://problem/84172685>
Comment 2 Devin Rousso 2021-10-21 14:48:14 PDT 
Created attachment 442065 [details]
Patch
Comment 3 Devin Rousso 2021-10-21 14:50:45 PDT 
Comment on attachment 442065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442065&action=review

> Source/WebCore/page/FrameView.cpp:-5640
> -    // Use the large size if no override is given since it's considered the default size.
> -    // if (m_largeViewportSizeOverride) {

I accidentally left this in when I was working on fixing EWS test failures for <https://webkit.org/b/219287> 😅
Comment 4 Tim Horton 2021-11-04 13:55:09 PDT 
Comment on attachment 442065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442065&action=review

> Source/WebCore/ChangeLog:9
> +        Views can be fractional pixels wide. We should not round, especially since viewport units

>Views can be fractional pixels wide.

Technically true but many other parts of WebKit do not correctly support even fractional *points* let alone fractional pixels. (Though I think you meant points anyway?).

Still, no harm in this change.
Comment 5 Devin Rousso 2021-11-04 20:40:22 PDT 
Created attachment 443373 [details]
Patch
Comment 6 EWS 2021-11-05 10:43:40 PDT 
Committed r285345 (243906@main): <https://commits.webkit.org/243906@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443373 [details].