Bug 231599 - [PlayStation] Enable RemoteInspector by default
Summary: [PlayStation] Enable RemoteInspector by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-12 11:21 PDT by Basuke Suzuki
Modified: 2021-10-12 17:20 PDT (History)
8 users (show)

See Also:


Attachments
PATCH (1.94 KB, patch)
2021-10-12 11:26 PDT, Basuke Suzuki
Hironori.Fujii: review+
Details | Formatted Diff | Diff
PATCH (1.94 KB, patch)
2021-10-12 14:12 PDT, Basuke Suzuki
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
PATCH (1.94 KB, patch)
2021-10-12 14:50 PDT, Basuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2021-10-12 11:21:37 PDT
It is treated as experimental feature right now. We need this in any case.
Comment 1 Basuke Suzuki 2021-10-12 11:26:03 PDT
Created attachment 440961 [details]
PATCH
Comment 2 Fujii Hironori 2021-10-12 12:44:59 PDT
Comment on attachment 440961 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=440961&action=review

> ChangeLog:8
> +        It is treated as experimental feature right now but we depends on this in various situation.

I think most WebKit developers are using present tense and the word "now" to describe the behavior of after the patch applied.
Comment 3 Basuke Suzuki 2021-10-12 14:12:03 PDT
Created attachment 440978 [details]
PATCH

Thanks. I've changed the sentence with your advice.
Comment 4 EWS 2021-10-12 14:13:10 PDT
Hironori Fujii found in /Volumes/Data/worker/Commit-Queue/build/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/worker/Commit-Queue/build/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 5 Fujii Hironori 2021-10-12 14:15:12 PDT
(In reply to EWS from comment #4)
> Hironori Fujii found in /Volumes/Data/worker/Commit-Queue/build/ChangeLog
> does not appear to be a valid reviewer according to contributors.json.
> /Volumes/Data/worker/Commit-Queue/build/ChangeLog neither lists a valid
> reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case
> insensitive).

😁 I'm using my filmily name first.
Comment 6 Basuke Suzuki 2021-10-12 14:50:42 PDT
Created attachment 440987 [details]
PATCH

OMG
Comment 7 EWS 2021-10-12 17:19:04 PDT
Committed r284065 (242894@main): <https://commits.webkit.org/242894@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440987 [details].
Comment 8 Radar WebKit Bug Importer 2021-10-12 17:20:21 PDT
<rdar://problem/84174098>