WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
231599
[PlayStation] Enable RemoteInspector by default
https://bugs.webkit.org/show_bug.cgi?id=231599
Summary
[PlayStation] Enable RemoteInspector by default
Basuke Suzuki
Reported
2021-10-12 11:21:37 PDT
It is treated as experimental feature right now. We need this in any case.
Attachments
PATCH
(1.94 KB, patch)
2021-10-12 11:26 PDT
,
Basuke Suzuki
fujii.hironori
: review+
Details
Formatted Diff
Diff
PATCH
(1.94 KB, patch)
2021-10-12 14:12 PDT
,
Basuke Suzuki
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
PATCH
(1.94 KB, patch)
2021-10-12 14:50 PDT
,
Basuke Suzuki
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Basuke Suzuki
Comment 1
2021-10-12 11:26:03 PDT
Created
attachment 440961
[details]
PATCH
Fujii Hironori
Comment 2
2021-10-12 12:44:59 PDT
Comment on
attachment 440961
[details]
PATCH View in context:
https://bugs.webkit.org/attachment.cgi?id=440961&action=review
> ChangeLog:8 > + It is treated as experimental feature right now but we depends on this in various situation.
I think most WebKit developers are using present tense and the word "now" to describe the behavior of after the patch applied.
Basuke Suzuki
Comment 3
2021-10-12 14:12:03 PDT
Created
attachment 440978
[details]
PATCH Thanks. I've changed the sentence with your advice.
EWS
Comment 4
2021-10-12 14:13:10 PDT
Hironori Fujii found in /Volumes/Data/worker/Commit-Queue/build/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/worker/Commit-Queue/build/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Fujii Hironori
Comment 5
2021-10-12 14:15:12 PDT
(In reply to EWS from
comment #4
)
> Hironori Fujii found in /Volumes/Data/worker/Commit-Queue/build/ChangeLog > does not appear to be a valid reviewer according to contributors.json. > /Volumes/Data/worker/Commit-Queue/build/ChangeLog neither lists a valid > reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case > insensitive).
😁 I'm using my filmily name first.
Basuke Suzuki
Comment 6
2021-10-12 14:50:42 PDT
Created
attachment 440987
[details]
PATCH OMG
EWS
Comment 7
2021-10-12 17:19:04 PDT
Committed
r284065
(
242894@main
): <
https://commits.webkit.org/242894@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 440987
[details]
.
Radar WebKit Bug Importer
Comment 8
2021-10-12 17:20:21 PDT
<
rdar://problem/84174098
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug