Bug 231582 - Use STL instead of WTF::get_if, WTF::Monostate, WTF::visit, and WTF::holds_alternative
Summary: Use STL instead of WTF::get_if, WTF::Monostate, WTF::visit, and WTF::holds_al...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-12 08:59 PDT by Alex Christensen
Modified: 2021-10-12 13:45 PDT (History)
43 users (show)

See Also:

Attachments
Patch (165.86 KB, patch)
2021-10-12 09:00 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-10-12 08:59:30 PDT 
Use STL instead of WTF::get_if, WTF::Monostate, WTF::visit, and WTF::holds_alternative
Comment 1 Alex Christensen 2021-10-12 09:00:14 PDT 
Created attachment 440942 [details]
Patch
Comment 2 Darin Adler 2021-10-12 09:04:26 PDT 
Comment on attachment 440942 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440942&action=review

r=me assuming compile succeeds (which I assume it will since this was done with global replace, I hope)

> Source/JavaScriptCore/ChangeLog:3
> +        Use STL instead of WTF::get_if, WTF::Monostate, WTF::visit, and WTF::holds_alternative

Pedantic terminology nitpick: The term "STL" is a bit archaic and I don’t think it applies here; you just mean the C++ standard library.
Comment 3 EWS 2021-10-12 13:43:58 PDT 
Committed r284016 (242853@main): <https://commits.webkit.org/242853@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440942 [details].
Comment 4 Radar WebKit Bug Importer 2021-10-12 13:45:19 PDT 
<rdar://problem/84164480>