Bug 231577 - [webkitscmpy] List reviewers for pull-request
Summary: [webkitscmpy] List reviewers for pull-request
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-12 07:40 PDT by Jonathan Bedard
Modified: 2021-10-13 15:09 PDT (History)
3 users (show)

See Also:

Attachments
Patch (24.41 KB, patch)
2021-10-12 07:48 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (24.45 KB, patch)
2021-10-13 08:11 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (25.79 KB, patch)
2021-10-13 13:51 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-10-12 07:40:19 PDT 
We need to be able to list the set of reviewers who are involved in a pull-request. In particular, we need to be able to list the set of reviewers who have approved or are blocking a particular pull-request.
Comment 1 Radar WebKit Bug Importer 2021-10-12 07:40:45 PDT 
<rdar://problem/84146807>
Comment 2 Jonathan Bedard 2021-10-12 07:48:45 PDT 
Created attachment 440931 [details]
Patch
Comment 3 Jonathan Bedard 2021-10-12 07:49:08 PDT 
Pull-request: https://github.com/WebKit/WebKit/pull/14
Comment 4 dewei_zhu 2021-10-13 00:04:50 PDT 
Comment on attachment 440931 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440931&action=review

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py:86
> +            elif not opened:

This seems a bit awkward. Because if `opened=1` it will slip through both condition check. Maybe we should `assert opened in [True, False, None]` at the beginning?
Another way is to use enum.Flag (new in python3.6, https://docs.python.org/3/library/enum.html) which supports bitwise operation.
Comment 5 Jonathan Bedard 2021-10-13 08:11:43 PDT 
Created attachment 441079 [details]
Patch
Comment 6 dewei_zhu 2021-10-13 12:46:17 PDT 
Comment on attachment 441079 [details]
Patch

r=me
Comment 7 Jonathan Bedard 2021-10-13 13:51:06 PDT 
Created attachment 441131 [details]
Patch for landing
Comment 8 EWS 2021-10-13 15:09:50 PDT 
Committed r284128 (242948@main): <https://commits.webkit.org/242948@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441131 [details].