Bug 231574 - Expose MediaCapabilities to Workers
Summary: Expose MediaCapabilities to Workers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 231568
Blocks:
  Show dependency tree / graph
 
Reported: 2021-10-12 07:28 PDT by youenn fablet
Modified: 2021-10-19 04:06 PDT (History)
15 users (show)

See Also:

Attachments
Patch (74.58 KB, patch)
2021-10-12 07:49 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (74.37 KB, patch)
2021-10-15 00:02 PDT, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (87.93 KB, patch)
2021-10-15 00:27 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (87.96 KB, patch)
2021-10-15 06:09 PDT, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (88.03 KB, patch)
2021-10-15 06:36 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (88.28 KB, patch)
2021-10-18 05:10 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (88.73 KB, patch)
2021-10-19 01:04 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-10-12 07:28:27 PDT 
Expose MediaCapabilities to Workers
Comment 1 youenn fablet 2021-10-12 07:49:09 PDT 
Created attachment 440932 [details]
Patch
Comment 2 youenn fablet 2021-10-15 00:02:15 PDT 
Created attachment 441340 [details]
Patch
Comment 3 EWS Watchlist 2021-10-15 00:03:15 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 4 youenn fablet 2021-10-15 00:27:33 PDT 
Created attachment 441341 [details]
Patch
Comment 5 youenn fablet 2021-10-15 00:28:24 PDT 
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/31261
Comment 6 youenn fablet 2021-10-15 06:09:44 PDT 
Created attachment 441369 [details]
Patch
Comment 7 youenn fablet 2021-10-15 06:36:16 PDT 
Created attachment 441370 [details]
Patch
Comment 8 youenn fablet 2021-10-18 05:10:36 PDT 
Created attachment 441587 [details]
Patch
Comment 9 Eric Carlson 2021-10-18 09:17:03 PDT 
Comment on attachment 441587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441587&action=review

> Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:-197
> -#if !RELEASE_LOG_DISABLED
> -        logger->info(LogMedia, identifier, " - Rejected. configuration: ", configuration);
> -#endif

Why not log the error?
Comment 10 youenn fablet 2021-10-19 01:04:17 PDT 
Created attachment 441698 [details]
Patch for landing
Comment 11 youenn fablet 2021-10-19 01:05:02 PDT 
(In reply to Eric Carlson from comment #9)
> Comment on attachment 441587 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=441587&action=review
> 
> > Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:-197
> > -#if !RELEASE_LOG_DISABLED
> > -        logger->info(LogMedia, identifier, " - Rejected. configuration: ", configuration);
> > -#endif
> 
> Why not log the error?

I added it back
Comment 12 EWS 2021-10-19 04:05:26 PDT 
Committed r284443 (243205@main): <https://commits.webkit.org/243205@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441698 [details].
Comment 13 Radar WebKit Bug Importer 2021-10-19 04:06:19 PDT 
<rdar://problem/84409518>