Bug 231571 - Eliminate duplicated platform-specific code in ScrollingTreeStickyNode
Summary: Eliminate duplicated platform-specific code in ScrollingTreeStickyNode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-12 05:48 PDT by Martin Robinson
Modified: 2021-10-27 04:47 PDT (History)
12 users (show)

See Also:


Attachments
Patch (64.62 KB, patch)
2021-10-13 04:45 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff
Patch (65.27 KB, patch)
2021-10-13 06:03 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff
Patch (65.44 KB, patch)
2021-10-13 12:03 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff
Patch (65.47 KB, patch)
2021-10-27 03:33 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2021-10-12 05:48:10 PDT
Both the Nicosia and Cocoa ports duplicate code specific to making sticky nodes work in the scrolling tree. Instead, this code could be moved to a shared class.
Comment 1 Simon Fraser (smfr) 2021-10-12 09:38:19 PDT
Overflow and frame scrolling nodes also share a bit of code.
Comment 2 Martin Robinson 2021-10-13 04:45:46 PDT
Created attachment 441056 [details]
Patch
Comment 3 Martin Robinson 2021-10-13 06:03:23 PDT
Created attachment 441064 [details]
Patch
Comment 4 Martin Robinson 2021-10-13 12:03:23 PDT
Created attachment 441117 [details]
Patch
Comment 5 Radar WebKit Bug Importer 2021-10-19 05:49:19 PDT
<rdar://problem/84411658>
Comment 6 Martin Robinson 2021-10-27 03:33:36 PDT
Created attachment 442576 [details]
Patch
Comment 7 EWS 2021-10-27 04:47:36 PDT
Committed r284920 (243591@main): <https://commits.webkit.org/243591@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442576 [details].