WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
231569
MediaCapabilities should enqueue a task to resolve promises
https://bugs.webkit.org/show_bug.cgi?id=231569
Summary
MediaCapabilities should enqueue a task to resolve promises
youenn fablet
Reported
2021-10-12 05:19:56 PDT
MediaCapabilities should enqueue a task to resolve promises
Attachments
Patch
(10.46 KB, patch)
2021-10-12 05:21 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Patch for landing
(10.55 KB, patch)
2021-10-14 04:04 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
youenn fablet
Comment 1
2021-10-12 05:21:43 PDT
Created
attachment 440918
[details]
Patch
Eric Carlson
Comment 2
2021-10-13 08:53:35 PDT
Comment on
attachment 440918
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=440918&action=review
> Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:215 > logger->info(LogMedia, identifier, "::callback() - Resolved. info: ", info);
It looks like this indentation is wrong now
> Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:269 > + logger->info(LogMedia, identifier, "::callback() - Resolved. info: ", info);
Ditto
youenn fablet
Comment 3
2021-10-14 04:04:05 PDT
Created
attachment 441201
[details]
Patch for landing
youenn fablet
Comment 4
2021-10-14 04:04:20 PDT
(In reply to Eric Carlson from
comment #2
)
> Comment on
attachment 440918
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=440918&action=review
> > > Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:215 > > logger->info(LogMedia, identifier, "::callback() - Resolved. info: ", info); > > It looks like this indentation is wrong now > > > Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:269 > > + logger->info(LogMedia, identifier, "::callback() - Resolved. info: ", info); > > Ditto
Fixed in landing patch
EWS
Comment 5
2021-10-14 23:33:11 PDT
Committed
r284236
(
243045@main
): <
https://commits.webkit.org/243045@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 441201
[details]
.
Radar WebKit Bug Importer
Comment 6
2021-10-14 23:34:17 PDT
<
rdar://problem/84290404
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug