Bug 231569 - MediaCapabilities should enqueue a task to resolve promises
Summary: MediaCapabilities should enqueue a task to resolve promises
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 231568
Blocks:
  Show dependency tree / graph
 
Reported: 2021-10-12 05:19 PDT by youenn fablet
Modified: 2021-10-14 23:34 PDT (History)
8 users (show)

See Also:

Attachments
Patch (10.46 KB, patch)
2021-10-12 05:21 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (10.55 KB, patch)
2021-10-14 04:04 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-10-12 05:19:56 PDT 
MediaCapabilities should enqueue a task to resolve promises
Comment 1 youenn fablet 2021-10-12 05:21:43 PDT 
Created attachment 440918 [details]
Patch
Comment 2 Eric Carlson 2021-10-13 08:53:35 PDT 
Comment on attachment 440918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440918&action=review

> Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:215
>              logger->info(LogMedia, identifier, "::callback() - Resolved. info: ", info);

It looks like this indentation is wrong now

> Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:269
> +            logger->info(LogMedia, identifier, "::callback() - Resolved. info: ", info);

Ditto
Comment 3 youenn fablet 2021-10-14 04:04:05 PDT 
Created attachment 441201 [details]
Patch for landing
Comment 4 youenn fablet 2021-10-14 04:04:20 PDT 
(In reply to Eric Carlson from comment #2)
> Comment on attachment 440918 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=440918&action=review
> 
> > Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:215
> >              logger->info(LogMedia, identifier, "::callback() - Resolved. info: ", info);
> 
> It looks like this indentation is wrong now
> 
> > Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:269
> > +            logger->info(LogMedia, identifier, "::callback() - Resolved. info: ", info);
> 
> Ditto

Fixed in landing patch
Comment 5 EWS 2021-10-14 23:33:11 PDT 
Committed r284236 (243045@main): <https://commits.webkit.org/243045@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441201 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-14 23:34:17 PDT 
<rdar://problem/84290404>