Bug 231565 - Add an override stylesheet for the alternate form control design
Summary: Add an override stylesheet for the alternate form control design
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-12 01:33 PDT by Tim Horton
Modified: 2021-10-12 13:08 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.94 KB, patch)
2021-10-12 01:34 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2021-10-12 01:33:10 PDT 
Add an override stylesheet for the alternate form control design
Comment 1 Tim Horton 2021-10-12 01:34:32 PDT 
Created attachment 440907 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-10-12 01:35:13 PDT 
<rdar://problem/84137252>
Comment 3 Devin Rousso 2021-10-12 11:20:57 PDT 
Comment on attachment 440907 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440907&action=review

r=me

> Source/WebCore/DerivedSources.make:1587
> +POSSIBLE_ADDITIONAL_USER_AGENT_STYLE_SHEETS = \

`POSSIBLE` makes it sound like not all of the things in this list will actually exist.  Is that accurate?  Would `RESOLVED` be a better name?
Comment 4 Tim Horton 2021-10-12 11:22:51 PDT 
(In reply to Devin Rousso from comment #3)
> Comment on attachment 440907 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=440907&action=review
> 
> r=me
> 
> > Source/WebCore/DerivedSources.make:1587
> > +POSSIBLE_ADDITIONAL_USER_AGENT_STYLE_SHEETS = \
> 
> `POSSIBLE` makes it sound like not all of the things in this list will
> actually exist.  Is that accurate?  Would `RESOLVED` be a better name?

The name matches the media controls one that is adjacent. But, maybe?
Comment 5 EWS 2021-10-12 13:08:22 PDT 
Committed r284008 (242850@main): <https://commits.webkit.org/242850@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440907 [details].