Bug 231561 - [LFC][Integration] Add support for painting inline box decorations
Summary: [LFC][Integration] Add support for painting inline box decorations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks: 231556 231562
  Show dependency tree / graph
 
Reported: 2021-10-12 00:08 PDT by Antti Koivisto
Modified: 2021-10-12 08:45 PDT (History)
10 users (show)

See Also:

Attachments
Patch (12.59 KB, patch)
2021-10-12 00:23 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (12.74 KB, patch)
2021-10-12 02:50 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (12.72 KB, patch)
2021-10-12 07:09 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-10-12 00:08:28 PDT 
Borders, backgrounds etc
Comment 1 Antti Koivisto 2021-10-12 00:23:42 PDT 
Created attachment 440902 [details]
Patch
Comment 2 Antti Koivisto 2021-10-12 02:50:42 PDT 
Created attachment 440914 [details]
Patch
Comment 3 zalan 2021-10-12 06:19:05 PDT 
Comment on attachment 440914 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440914&action=review

> Source/WebCore/ChangeLog:27
> +        (WebCore::LayoutIntegration::LineLayout::paintTextBoxUsingPhysicalCoordinates): Deleted.

InlineBoxPainter does the coordinate flipping now?
Comment 4 Antti Koivisto 2021-10-12 07:07:51 PDT 
> InlineBoxPainter does the coordinate flipping now?

Always did.
Comment 5 Antti Koivisto 2021-10-12 07:09:19 PDT 
Created attachment 440925 [details]
Patch
Comment 6 EWS 2021-10-12 08:44:05 PDT 
Committed r283981 (242827@main): <https://commits.webkit.org/242827@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440925 [details].
Comment 7 Radar WebKit Bug Importer 2021-10-12 08:45:55 PDT 
<rdar://problem/84148970>