Bug 231560 - Implement alternate style for textarea
Summary: Implement alternate style for textarea
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-11 23:35 PDT by Tim Horton
Modified: 2021-10-12 18:00 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.25 KB, patch)
2021-10-11 23:38 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (3.30 KB, patch)
2021-10-12 15:19 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2021-10-11 23:35:37 PDT 
Implement alternate style for textarea
Comment 1 Tim Horton 2021-10-11 23:38:44 PDT 
Created attachment 440899 [details]
Patch
Comment 2 Devin Rousso 2021-10-12 11:18:31 PDT 
Comment on attachment 440899 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440899&action=review

r=me

> Source/WebCore/rendering/RenderThemeIOS.mm:607
> +        if (is<HTMLTextAreaElement>(*element))

NIT: Should this be an `else if` so we don't check it if we enter the `if (is<HTMLInputElement>(*element))` above?

> Source/WebCore/rendering/RenderThemeIOS.mm:641
> +    bool useAlternateDesign = element->document().settings().alternateFormControlDesignEnabled();

NIT: Does this need to be a separate variable?
Comment 3 Tim Horton 2021-10-12 11:23:11 PDT 
Both fair!
Comment 4 Tim Horton 2021-10-12 15:19:50 PDT 
Created attachment 441000 [details]
Patch
Comment 5 Radar WebKit Bug Importer 2021-10-12 15:35:58 PDT 
<rdar://problem/84169599>
Comment 6 EWS 2021-10-12 18:00:04 PDT 
Committed r284070 (242898@main): <https://commits.webkit.org/242898@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441000 [details].