Bug 231553 - PCM: Cherry-picking patch for branch (Oct 2021)
Summary: PCM: Cherry-picking patch for branch (Oct 2021)
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-11 21:13 PDT by John Wilander
Modified: 2023-07-20 15:17 PDT (History)
4 users (show)

See Also:

Attachments
Cherry-pick patch (66.03 KB, patch)
2021-10-11 21:16 PDT, John Wilander 		wilander: commit-queue-
Details | Formatted Diff | Diff
Patch with better explanation of the fix for the test case. (66.33 KB, patch)
2021-10-12 08:16 PDT, John Wilander 		achristensen: review+
wilander: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2021-10-11 21:13:56 PDT 
This is just a bug to allow for review of a branch-specific patch. It won't apply to trunk.
Comment 1 Radar WebKit Bug Importer 2021-10-11 21:14:30 PDT 
<rdar://problem/84130892>
Comment 2 John Wilander 2021-10-11 21:16:41 PDT 
Created attachment 440883 [details]
Cherry-pick patch
Comment 3 Alex Christensen 2021-10-11 21:46:56 PDT 
Comment on attachment 440883 [details]
Cherry-pick patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440883&action=review

> LayoutTests/ChangeLog:7
> +        Plus a fix of an API test that was timing out.

Could you describe this change more?  What part of the patch is this?  Why was it needed?  What was missed before?
Comment 4 John Wilander 2021-10-12 08:15:15 PDT 
Comment on attachment 440883 [details]
Cherry-pick patch

New patch with explanation for the fixed test case coming up.
Comment 5 John Wilander 2021-10-12 08:16:08 PDT 
Created attachment 440935 [details]
Patch with better explanation of the fix for the test case.
Comment 6 John Wilander 2021-10-12 08:17:41 PDT 
See the Tools change log for the updated description.
Comment 7 Alex Christensen 2021-10-12 08:37:52 PDT 
Comment on attachment 440935 [details]
Patch with better explanation of the fix for the test case.

This is good.  The parts of the original change in PrivateClickMeasurementManagerInterface and PrivateClickMeasurementManagerProxy are not needed because those abstractions don't exist on the branch, but this does all the functional change of the original.  The included interface simplification does not change behavior.  r=me
Comment 8 Kate Cheney 2021-10-12 08:55:22 PDT 
Comment on attachment 440935 [details]
Patch with better explanation of the fix for the test case.

View in context: https://bugs.webkit.org/attachment.cgi?id=440935&action=review

LGTM

> Source/WebKit/NetworkProcess/NetworkSession.h:140
> +    void setPrivateClickMeasurementAppBundleIDForTesting(String&& appBundleIDForTesting);

unnecessary parameter name.
Comment 9 John Wilander 2021-10-12 10:59:16 PDT 
(In reply to Kate Cheney from comment #8)
> Comment on attachment 440935 [details]
> Patch with better explanation of the fix for the test case.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=440935&action=review
> 
> LGTM
> 
> > Source/WebKit/NetworkProcess/NetworkSession.h:140
> > +    void setPrivateClickMeasurementAppBundleIDForTesting(String&& appBundleIDForTesting);
> 
> unnecessary parameter name.

Fixed.

Thanks, both of you! I appreciate it.