RESOLVED FIXED 231549
Modernize WebDatabaseManagerClient 
https://bugs.webkit.org/show_bug.cgi?id=231549
Summary Modernize WebDatabaseManagerClient
David Kilzer (:ddkilzer)
Reported 2021-10-11 20:01:43 PDT
Modernize WebDatabaseManagerClient. Originally I was going to make WebDatabaseManagerClient use a weak observer with CFNotificationCenter, but this isn't needed since it uses a singleton pattern. So what's left is a bit of clean-up: - Put WebDatabaseManagerClient in C++ namespace of "WebKit". - Change WebDatabaseManagerClient::sharedWebDatabaseManagerClient() to use NeverDestroyed<> and to return a reference.
Attachments
Patch v1 (5.30 KB, patch)
2021-10-11 20:04 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-11 20:02:37 PDT
<rdar://problem/84129168>
David Kilzer (:ddkilzer)
Comment 2 2021-10-11 20:04:34 PDT
Created attachment 440875 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 3 2021-10-12 11:46:05 PDT
(In reply to David Kilzer (:ddkilzer) from comment #2) > Created attachment 440875 [details] > Patch v1 The `api-gtk` failures are likely unrelated to this change as the `gtk` build succeeds. The WebDatabaseManagerClient class is not used by GTK.
Sihui Liu
Comment 4 2021-10-14 10:21:35 PDT
Comment on attachment 440875 [details] Patch v1 r=me
EWS
Comment 5 2021-10-14 11:02:32 PDT
Committed r284177 (242994@main): <https://commits.webkit.org/242994@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440875 [details].
Note You need to log in before you can comment on or make changes to this bug.