Bug 231533 - Fix makeprop.pl to not treat "inherited: false" properties as inherited.
Summary: Fix makeprop.pl to not treat "inherited: false" properties as inherited.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-11 14:03 PDT by Kiet Ho
Modified: 2021-10-12 08:38 PDT (History)
11 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2021-10-11 14:23 PDT, Kiet Ho 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kiet Ho 2021-10-11 14:03:24 PDT 
makeprop.pl treats a property as inherited if the "inherited" option in CSSProperties.json is defined, regardless of whether the option value is true or false. Fix makeprop.pl to actually consider the option value.
Comment 1 Kiet Ho 2021-10-11 14:23:13 PDT 
Created attachment 440834 [details]
Patch
Comment 2 EWS 2021-10-11 19:48:39 PDT 
Committed r283963 (242810@main): <https://commits.webkit.org/242810@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440834 [details].
Comment 3 Radar WebKit Bug Importer 2021-10-11 19:49:18 PDT 
<rdar://problem/84128720>
Comment 4 Darin Adler 2021-10-12 08:38:43 PDT 
Why no tests? Doesn’t this affect anything?