Bug 23153 - JSC build always touches JavaScriptCore/docs/bytecode.html
Summary: JSC build always touches JavaScriptCore/docs/bytecode.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-06 16:11 PST by Greg Bolsinga
Modified: 2009-01-14 21:41 PST (History)
3 users (show)

See Also:


Attachments
Patch v1 (4.58 KB, patch)
2009-01-14 18:40 PST, David Kilzer (:ddkilzer)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Bolsinga 2009-01-06 16:11:25 PST
This file is in the repository, and git thinks it is modified after a build. This is in the SRC_ROOT, and should be treated as read-only.
Comment 1 Mark Rowe (bdash) 2009-01-06 22:34:12 PST
This is super-annoying, since the generated file is of no value to the vast majority of people working on the project.  I suspect that even those that work on JSCore would refer to the source for information on the bytecodes rather than generated file.
Comment 2 David Kilzer (:ddkilzer) 2009-01-14 18:40:43 PST
Created attachment 26742 [details]
Patch v1

Proposed fix.
Comment 3 Darin Adler 2009-01-14 20:35:21 PST
Comment on attachment 26742 [details]
Patch v1

r=me
Comment 4 David Kilzer (:ddkilzer) 2009-01-14 21:41:08 PST
$ git svn dcommit
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/DerivedSources.make
	M	JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
	M	JavaScriptCore/docs/make-bytecode-docs.pl
Committed r39931

http://trac.webkit.org/changeset/39931