Bug 231527 - [build-imagediff] Build universal binaries by default
Summary: [build-imagediff] Build universal binaries by default
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
Keywords: InRadar
Depends on:
Reported: 2021-10-11 13:18 PDT by Jonathan Bedard
Modified: 2021-10-11 15:20 PDT (History)
4 users (show)

See Also:

Patch (1.02 KB, patch)
2021-10-11 13:20 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-10-11 13:18:53 PDT
ImageDiff is a small enough program that we should really just always builds it with both x86 and arm64 on Mac.
Comment 1 Radar WebKit Bug Importer 2021-10-11 13:19:26 PDT
Comment 2 Jonathan Bedard 2021-10-11 13:20:21 PDT
Created attachment 440829 [details]
Comment 3 Ryan Haddad 2021-10-11 14:07:13 PDT
Comment on attachment 440829 [details]

Seems reasonable to me.
Comment 4 Jonathan Bedard 2021-10-11 14:37:18 PDT
Some context, we know we need this for our arm Simulator bots:
Comment 5 EWS 2021-10-11 15:20:03 PDT
Committed r283939 (242798@main): <https://commits.webkit.org/242798@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440829 [details].