WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
231527
[build-imagediff] Build universal binaries by default
https://bugs.webkit.org/show_bug.cgi?id=231527
Summary
[build-imagediff] Build universal binaries by default
Jonathan Bedard
Reported
2021-10-11 13:18:53 PDT
ImageDiff is a small enough program that we should really just always builds it with both x86 and arm64 on Mac.
Attachments
Patch
(1.02 KB, patch)
2021-10-11 13:20 PDT
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2021-10-11 13:19:26 PDT
<
rdar://problem/84113091
>
Jonathan Bedard
Comment 2
2021-10-11 13:20:21 PDT
Created
attachment 440829
[details]
Patch
Ryan Haddad
Comment 3
2021-10-11 14:07:13 PDT
Comment on
attachment 440829
[details]
Patch Seems reasonable to me.
Jonathan Bedard
Comment 4
2021-10-11 14:37:18 PDT
Some context, we know we need this for our arm Simulator bots:
https://build.webkit.org/#/builders/298/builds/2
EWS
Comment 5
2021-10-11 15:20:03 PDT
Committed
r283939
(
242798@main
): <
https://commits.webkit.org/242798@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 440829
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug