WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 23151
Finish rename of AffineTransform
https://bugs.webkit.org/show_bug.cgi?id=23151
Summary
Finish rename of AffineTransform
Dean Jackson
Reported
2009-01-06 14:57:03 PST
The platform interfaces kept the old name. They should be renamed. While I'm in there, I'll also remove the trailing whitespaces that zecke complained about (seems to have been in the file for a while).
Attachments
patch
(39.70 KB, patch)
2009-01-06 15:20 PST
,
Dean Jackson
no flags
Details
Formatted Diff
Diff
patch to finish renaming
(68.49 KB, patch)
2009-01-06 15:40 PST
,
Dean Jackson
darin
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Dean Jackson
Comment 1
2009-01-06 15:20:18 PST
Created
attachment 26477
[details]
patch Hopefully this finishes the rename makes zecke happier at the same time :)
Dean Jackson
Comment 2
2009-01-06 15:22:09 PST
Comment on
attachment 26477
[details]
patch arrgh. wrong file uploaded.
Dean Jackson
Comment 3
2009-01-06 15:40:54 PST
Created
attachment 26478
[details]
patch to finish renaming Hopefully got the right file this time.
Darin Adler
Comment 4
2009-01-06 16:02:31 PST
Comment on
attachment 26478
[details]
patch to finish renaming Best way to do this: 1) Use do-webcore-rename 2) grep for AffineTransform in tree after rename 3) Update list of things in do-webcore-rename to cover more 4) Revert your changes to the tree 5) Use do-webcore-rename Repeat until done. Then send patch. Then do any hand changes, separately, in another patch. For next time. It's a little strange that this patch includes stripping trailing whitespace in TransformationMatrix.h and TransformationMatrics.cpp. r=me
Dean Jackson
Comment 5
2009-01-07 15:09:40 PST
See above comments for reasoning on whitespace changes. Sending WebCore/ChangeLog Sending WebCore/GNUmakefile.am Sending WebCore/WebCore.pro Sending WebCore/WebCore.scons Sending WebCore/WebCore.vcproj/WebCore.vcproj Sending WebCore/WebCore.xcodeproj/project.pbxproj Deleting WebCore/platform/graphics/cairo/AffineTransformCairo.cpp Adding WebCore/platform/graphics/cairo/TransformationMatrixCairo.cpp Deleting WebCore/platform/graphics/cg/AffineTransformCG.cpp Adding WebCore/platform/graphics/cg/TransformationMatrixCG.cpp Deleting WebCore/platform/graphics/qt/AffineTransformQt.cpp Adding WebCore/platform/graphics/qt/TransformationMatrixQt.cpp Sending WebCore/platform/graphics/transforms/TransformationMatrix.cpp Sending WebCore/platform/graphics/transforms/TransformationMatrix.h Deleting WebCore/platform/graphics/wx/AffineTransformWx.cpp Adding WebCore/platform/graphics/wx/TransformationMatrixWx.cpp Sending WebCore/webcore-wx.bkl Transmitting file data .......... Committed revision 39688.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug