Bug 23151 - Finish rename of AffineTransform
Summary: Finish rename of AffineTransform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-06 14:57 PST by Dean Jackson
Modified: 2009-03-02 11:51 PST (History)
2 users (show)

See Also:


Attachments
patch (39.70 KB, patch)
2009-01-06 15:20 PST, Dean Jackson
no flags Details | Formatted Diff | Diff
patch to finish renaming (68.49 KB, patch)
2009-01-06 15:40 PST, Dean Jackson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2009-01-06 14:57:03 PST
The platform interfaces kept the old name. They should be renamed.

While I'm in there, I'll also remove the trailing whitespaces that zecke complained about (seems to have been in the file for a while).
Comment 1 Dean Jackson 2009-01-06 15:20:18 PST
Created attachment 26477 [details]
patch

Hopefully this finishes the rename makes zecke happier at the same time :)
Comment 2 Dean Jackson 2009-01-06 15:22:09 PST
Comment on attachment 26477 [details]
patch

arrgh. wrong file uploaded.
Comment 3 Dean Jackson 2009-01-06 15:40:54 PST
Created attachment 26478 [details]
patch to finish renaming

Hopefully got the right file this time.
Comment 4 Darin Adler 2009-01-06 16:02:31 PST
Comment on attachment 26478 [details]
patch to finish renaming

Best way to do this:

    1) Use do-webcore-rename
    2) grep for AffineTransform in tree after rename
    3) Update list of things in do-webcore-rename to cover more
    4) Revert your changes to the tree
    5) Use do-webcore-rename

Repeat until done.

Then send patch.

Then do any hand changes, separately, in another patch.

For next time.

It's a little strange that this patch includes stripping trailing whitespace in TransformationMatrix.h and TransformationMatrics.cpp.

r=me
Comment 5 Dean Jackson 2009-01-07 15:09:40 PST
See above comments for reasoning on whitespace changes.

Sending        WebCore/ChangeLog
Sending        WebCore/GNUmakefile.am
Sending        WebCore/WebCore.pro
Sending        WebCore/WebCore.scons
Sending        WebCore/WebCore.vcproj/WebCore.vcproj
Sending        WebCore/WebCore.xcodeproj/project.pbxproj
Deleting       WebCore/platform/graphics/cairo/AffineTransformCairo.cpp
Adding         WebCore/platform/graphics/cairo/TransformationMatrixCairo.cpp
Deleting       WebCore/platform/graphics/cg/AffineTransformCG.cpp
Adding         WebCore/platform/graphics/cg/TransformationMatrixCG.cpp
Deleting       WebCore/platform/graphics/qt/AffineTransformQt.cpp
Adding         WebCore/platform/graphics/qt/TransformationMatrixQt.cpp
Sending        WebCore/platform/graphics/transforms/TransformationMatrix.cpp
Sending        WebCore/platform/graphics/transforms/TransformationMatrix.h
Deleting       WebCore/platform/graphics/wx/AffineTransformWx.cpp
Adding         WebCore/platform/graphics/wx/TransformationMatrixWx.cpp
Sending        WebCore/webcore-wx.bkl
Transmitting file data ..........
Committed revision 39688.