Bug 231508 - [iOS] Add syscall telemetry in the WebContent process' sandbox
Summary: [iOS] Add syscall telemetry in the WebContent process' sandbox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-11 04:08 PDT by Per Arne Vollan
Modified: 2021-10-12 04:02 PDT (History)
4 users (show)

See Also:


Attachments
Patch (16.40 KB, patch)
2021-10-11 14:19 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (19.17 KB, patch)
2021-10-11 14:47 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-10-11 04:08:28 PDT
Add syscall telemetry in the WebContent process' sandbox to learn more about the context in which they are being used.
Comment 1 Radar WebKit Bug Importer 2021-10-11 04:08:59 PDT
<rdar://problem/84093924>
Comment 2 Per Arne Vollan 2021-10-11 14:17:21 PDT
<rdar://83197060>
Comment 3 Per Arne Vollan 2021-10-11 14:19:40 PDT
Created attachment 440833 [details]
Patch
Comment 4 Per Arne Vollan 2021-10-11 14:47:28 PDT
Created attachment 440839 [details]
Patch
Comment 5 Brent Fulgham 2021-10-11 15:37:28 PDT
Comment on attachment 440839 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440839&action=review

r=me

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:1508
> +            (allow mach-message-send (with telemetry-backtrace) (kernel-mig-routine

Do we need to add preprocessor macros (or a defined? check) for 'kernel-mig-routine'?
Comment 6 Per Arne Vollan 2021-10-12 03:59:16 PDT
(In reply to Brent Fulgham from comment #5)
> Comment on attachment 440839 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=440839&action=review
> 
> r=me
> 
> > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:1508
> > +            (allow mach-message-send (with telemetry-backtrace) (kernel-mig-routine
> 
> Do we need to add preprocessor macros (or a defined? check) for
> 'kernel-mig-routine'?

This is inside '(when (defined? 'mach-kernel-endpoint)', so I think that will guard against compile issues on older systems.

Thanks for reviewing!
Comment 7 EWS 2021-10-12 04:02:47 PDT
Committed r283978 (242824@main): <https://commits.webkit.org/242824@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440839 [details].