Bug 231500 - Beef up worker termination handling in ReadableStream routines
Summary: Beef up worker termination handling in ReadableStream routines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-11 01:22 PDT by youenn fablet
Modified: 2021-10-26 02:46 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.16 KB, patch)
2021-10-11 01:26 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-10-11 01:22:15 PDT 
Beef up worker termination handling in ReadableStream routines
Comment 1 youenn fablet 2021-10-11 01:23:13 PDT 
<rdar://83687915>
Comment 2 youenn fablet 2021-10-11 01:24:05 PDT 
I am not quite sure whether we need to check for termination after wrapping of an existing C++ object into a JS object. @Mark, any suggestion here?
Comment 3 youenn fablet 2021-10-11 01:26:31 PDT 
Created attachment 440763 [details]
Patch
Comment 4 Darin Adler 2021-10-25 14:50:01 PDT 
Comment on attachment 440763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440763&action=review

> Source/WebCore/ChangeLog:10
> +        Covered by existing tests.

How can that be true? Why do we need to "beef up" if nothing is changing?
Comment 5 youenn fablet 2021-10-26 02:11:37 PDT 
Comment on attachment 440763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440763&action=review

>> Source/WebCore/ChangeLog:10
>> +        Covered by existing tests.
> 
> How can that be true? Why do we need to "beef up" if nothing is changing?

We are adding more checks so code is changing.
I think it is covered by existing tests that are currently crashing on debug asserts, like https://bugs.webkit.org/show_bug.cgi?id=230984.
Comment 6 EWS 2021-10-26 02:46:36 PDT 
Committed r284861 (243538@main): <https://commits.webkit.org/243538@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440763 [details].