WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
23150
Node::registerDynamicNodeList has redundant checks in it
https://bugs.webkit.org/show_bug.cgi?id=23150
Summary
Node::registerDynamicNodeList has redundant checks in it
David Smith
Reported
2009-01-06 14:08:26 PST
All the callers of it do most of the work it does beforehand, so it can be greatly simplified.
Attachments
Fix
(3.27 KB, patch)
2009-01-06 14:09 PST
,
David Smith
eric
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Smith
Comment 1
2009-01-06 14:09:45 PST
Created
attachment 26474
[details]
Fix Tiny speedup on Dromaeo
Eric Seidel (no email)
Comment 2
2009-01-06 15:02:00 PST
Comment on
attachment 26474
[details]
Fix We talked about this over IRC. David's gonna post a new patch with some minor mods.
David Smith
Comment 3
2009-01-06 15:06:32 PST
Actually I'm pretty sure this isn't safe. The stuff at the callsites that I was relying on is only done in some cases. So it goes.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug