Bug 231485 - [LFC][IFC] Do no bail out on boundary neutral characters
Summary: [LFC][IFC] Do no bail out on boundary neutral characters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-09 19:49 PDT by zalan
Modified: 2021-10-10 13:48 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.23 KB, patch)
2021-10-09 19:52 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (7.00 KB, patch)
2021-10-10 06:37 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-10-09 19:49:20 PDT 
ssia
Comment 1 zalan 2021-10-09 19:52:03 PDT 
Created attachment 440723 [details]
Patch
Comment 2 zalan 2021-10-09 21:23:37 PDT 
They look progressions. will rebaseline.
Comment 3 Antti Koivisto 2021-10-09 22:13:05 PDT 
Comment on attachment 440723 [details]
Patch

The failure in fast/text/text-underline-first-line-decoration.html can be handled by altering the test or exceptions.
Comment 4 zalan 2021-10-10 06:37:16 PDT 
Created attachment 440727 [details]
Patch
Comment 5 Antti Koivisto 2021-10-10 07:16:35 PDT 
Comment on attachment 440727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440727&action=review

> LayoutTests/fast/text/text-underline-first-line-decoration-expected.html:11
> +<span style="text-decoration:underline">The first line <span style="vertical-align:-20px">has a decoration, but not </span></span><img style="vertical-align:-100px; height:20px;width:20px;background-color:lime"><span style="text-decoration:underline; vertical-align:-20px"> under the image.&ZeroWidthSpace;</span></span><br>

Probably don't need that ZeroWidthSpace there, it was just an earlier attempt to fix the test.
Comment 6 EWS 2021-10-10 09:05:53 PDT 
Committed r283875 (242752@main): <https://commits.webkit.org/242752@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440727 [details].
Comment 7 Radar WebKit Bug Importer 2021-10-10 09:06:20 PDT 
<rdar://problem/84076520>
Comment 8 zalan 2021-10-10 13:48:16 PDT 
(In reply to Antti Koivisto from comment #5)
> Comment on attachment 440727 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=440727&action=review
> 
> > LayoutTests/fast/text/text-underline-first-line-decoration-expected.html:11
> > +<span style="text-decoration:underline">The first line <span style="vertical-align:-20px">has a decoration, but not </span></span><img style="vertical-align:-100px; height:20px;width:20px;background-color:lime"><span style="text-decoration:underline; vertical-align:-20px"> under the image.&ZeroWidthSpace;</span></span><br>
> 
> Probably don't need that ZeroWidthSpace there, it was just an earlier
> attempt to fix the test.
:(