Bug 231478 – AX: AccessibilityMenuListPopup shouldn't add ignored children

• Status: NEW
• Component: Accessibility

[Tyler Wilcock]

An invariant of our accessibility tree is that it doesn't include things that are ignored. Most paths end up at AccessibilityObject::insertChild, which prevents ignored children from being inserted. However, AccessibilityMenuListPopup::addChildren directly calls m_children.append, so it should ensure the things it adds aren't ignored first.

[Radar WebKit Bug Importer]

<rdar://problem/84062657>

[Tyler Wilcock]

Created attachment 440711 [details]
Patch

[chris fleizach]

Comment on attachment 440711 [details]
Patch

Is it possible to add an example of an ignored menu list item in a layout test?

[Tyler Wilcock]

(In reply to chris fleizach from comment #3)
> Comment on attachment 440711 [details]
> Patch
> 
> Is it possible to add an example of an ignored menu list item in a layout
> test?

We can't test this because AccessibilityMenuListPopup is ignored on Mac and iOS, so its addChildren method never gets called, and thus we can't exercise the changed code. This patch would make this class do the right thing should it become un-ignored.

[chris fleizach]

Which platforms will this have an effect on?

[Andres Gonzalez]

(In reply to Tyler Wilcock from comment #4)
> (In reply to chris fleizach from comment #3)
> > Comment on attachment 440711 [details]
> > Patch
> > 
> > Is it possible to add an example of an ignored menu list item in a layout
> > test?
> 
> We can't test this because AccessibilityMenuListPopup is ignored on Mac and
> iOS, so its addChildren method never gets called, and thus we can't exercise
> the changed code. This patch would make this class do the right thing should
> it become un-ignored.

How can AccessibilityMenuListPopup become un-ignored?