Bug 231477 – Refactor RenderSVGBlock

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Rob Buis]

Refactor RenderSVGBlock.

[Rob Buis]

Created attachment 440710 [details]
Patch

[Rob Buis]

Created attachment 440957 [details]
Patch

[Rob Buis]

Niko, hopefully this would just be a small rebase for your accelerated SVG work?

[Manuel Rego Casasnovas]

Comment on attachment 440957 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440957&action=review

> Source/WebCore/rendering/svg/RenderSVGBlock.h:41
> +    LayoutRect clippedOverflowRect(const RenderLayerModelObject* repaintContainer, VisibleRectContext) const final;
> +    std::optional<FloatRect> computeFloatVisibleRectInContainer(const FloatRect&, const RenderLayerModelObject* container, VisibleRectContext) const final;
> +    std::optional<LayoutRect> computeVisibleRectInContainer(const LayoutRect&, const RenderLayerModelObject* container, VisibleRectContext) const final;
> +
> +    void mapLocalToContainer(const RenderLayerModelObject* ancestorContainer, TransformState&, OptionSet<MapCoordinatesMode>, bool* wasFixed) const final;
> +    const RenderObject* pushMappingToContainer(const RenderLayerModelObject* ancestorToStopAt, RenderGeometryMap&) const final;
> +
> +    bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) final;

Some of these methods used to be "private" in one of the subclasses, and now all are public. Do we really need all of them to be public or we can restrict this somehow?

[Rob Buis]

Created attachment 441198 [details]
Patch

[Manuel Rego Casasnovas]

Comment on attachment 441198 [details]
Patch

Nice catch, thanks for removing the duplicated code.

[EWS]

Committed r284154 (242974@main): <https://commits.webkit.org/242974@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441198 [details].

[Radar WebKit Bug Importer]

<rdar://problem/84251970>

[Said Abou-Hallawa]

Comment on attachment 441198 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441198&action=review

> Source/WebCore/ChangeLog:8
> +        Refactor common code from RenderSVGBlock subclasses into RenderSVGBlock.

Why are we doing this refactoring? I would expect few words here saying something like "Work towards bug #..." or a link to the blocked bug in the "Blocks" editor.