WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
231469
REGRESSION (
r283824
): Monterey tests are running on Big Sur
https://bugs.webkit.org/show_bug.cgi?id=231469
Summary
REGRESSION (r283824): Monterey tests are running on Big Sur
Simon Fraser (smfr)
Reported
2021-10-08 19:37:28 PDT
I am on Big Sur, but run-webkit-tests is running tests in fast/images/text-recognition which are marked as Skip, but enabled for Monterey: [ Monterey+ ] fast/images/text-recognition [ Pass ] Bots are also seeing this:
https://ews-build.s3-us-west-2.amazonaws.com/macOS-AppleSilicon-Big-Sur-Debug-WK2-Tests-EWS/r440671-14054/results.html
Attachments
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2021-10-08 19:39:55 PDT
Some debugging shows that run-webkit-tests things my OS is "monterey" despite being 11.3. This is coming from: CURRENT_VERSION = Version(12, 0) in class MacPort(DarwinPort). In that __init__ function, we seem to be hitting the default clause: if not self._os_version: self._os_version = MacPort.CURRENT_VERSION host.platform.os_version is correct. When running open source tests, apple_additions() is None.
Simon Fraser (smfr)
Comment 2
2021-10-08 19:46:02 PDT
Fixed in
https://trac.webkit.org/changeset/283850/webkit
.
Radar WebKit Bug Importer
Comment 3
2021-10-08 19:47:19 PDT
<
rdar://problem/84053307
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug