Bug 231469 - REGRESSION (r283824): Monterey tests are running on Big Sur
Summary: REGRESSION (r283824): Monterey tests are running on Big Sur
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-08 19:37 PDT by Simon Fraser (smfr)
Modified: 2021-10-08 19:47 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-10-08 19:37:28 PDT 
I am on Big Sur, but run-webkit-tests is running tests in fast/images/text-recognition which are marked as Skip, but enabled for Monterey:

[ Monterey+ ] fast/images/text-recognition [ Pass ]

Bots are also seeing this: https://ews-build.s3-us-west-2.amazonaws.com/macOS-AppleSilicon-Big-Sur-Debug-WK2-Tests-EWS/r440671-14054/results.html
Comment 1 Simon Fraser (smfr) 2021-10-08 19:39:55 PDT 
Some debugging shows that run-webkit-tests things my OS is "monterey" despite being 	11.3. This is coming from:

CURRENT_VERSION = Version(12, 0)

in class MacPort(DarwinPort). In that __init__ function, we seem to be hitting the default clause:

        if not self._os_version:
            self._os_version = MacPort.CURRENT_VERSION

host.platform.os_version is correct.

When running open source tests, apple_additions() is None.
Comment 2 Simon Fraser (smfr) 2021-10-08 19:46:02 PDT 
Fixed in https://trac.webkit.org/changeset/283850/webkit.
Comment 3 Radar WebKit Bug Importer 2021-10-08 19:47:19 PDT 
<rdar://problem/84053307>