Bug 231441 - Ensure that animated scrolls will run on the scrolling thread
Summary: Ensure that animated scrolls will run on the scrolling thread
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-08 11:33 PDT by Simon Fraser (smfr)
Modified: 2021-10-08 16:20 PDT (History)
11 users (show)

See Also:

Attachments
Patch (22.50 KB, patch)
2021-10-08 11:37 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (23.36 KB, patch)
2021-10-08 13:00 PDT, Simon Fraser (smfr) 		thorton: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-10-08 11:33:13 PDT 
Ensure that animated scrolls will run on the scrolling thread
Comment 1 Simon Fraser (smfr) 2021-10-08 11:37:56 PDT 
Created attachment 440650 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-10-08 13:00:18 PDT 
Created attachment 440660 [details]
Patch
Comment 3 Tim Horton 2021-10-08 14:00:58 PDT 
Comment on attachment 440660 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440660&action=review

> Source/WebCore/ChangeLog:8
> +        On macOS, scrolling tree commits run the main thread (holding a lock), so we can't start

missing an "on" I think

> Source/WebCore/ChangeLog:12
> +        to bounce to the scrolling tree to start animations. We also have intercept requested scroll

"we have intercept"
Comment 4 Simon Fraser (smfr) 2021-10-08 16:16:37 PDT 
https://trac.webkit.org/changeset/283849/webkit
Comment 5 Radar WebKit Bug Importer 2021-10-08 16:20:11 PDT 
<rdar://problem/84048278>