Bug 23144 - ScopeChain::push/pop look suspiciously unsafe
Summary: ScopeChain::push/pop look suspiciously unsafe
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-06 12:18 PST by Oliver Hunt
Modified: 2011-05-01 19:49 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2009-01-06 12:18:28 PST
Title says it all -- m_node is refed on construct, and deref'd in the destructor,m but push/pop don't appear to propagate this ref
Comment 1 Oliver Hunt 2011-05-01 19:49:34 PDT
scopechainnode is now gc allocated so no manual ref/deref