Bug 231431 - [ iOS14 EWS ] http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive.html is a flaky crash
Summary: [ iOS14 EWS ] http/tests/privateClickMeasurement/attribution-conversion-throu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-08 08:40 PDT by ayumi_kojima
Modified: 2021-10-25 17:14 PDT (History)
5 users (show)

See Also:

Attachments
Crash log (129.54 KB, text/plain)
2021-10-08 08:41 PDT, ayumi_kojima 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ayumi_kojima 2021-10-08 08:40:51 PDT 
http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive.html

Is a flaky crash on iOS-14-Simulator-WK2-Tests-EWS.

History: https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2FprivateClickMeasurement%2Fattribution-conversion-through-fetch-keepalive.html

It looks like the crash is only happening on EWS.

Result page: https://ews-build.s3-us-west-2.amazonaws.com/iOS-14-Simulator-WK2-Tests-EWS/r440583-22987/results.html

It looks like it started recently on this build https://ews-build.webkit.org/#/builders/51/builds/22800

No Stderr.
Comment 1 ayumi_kojima 2021-10-08 08:41:42 PDT 
Created attachment 440619 [details]
Crash log
Comment 2 Radar WebKit Bug Importer 2021-10-08 08:42:06 PDT 
<rdar://problem/84029425>
Comment 3 ayumi_kojima 2021-10-08 08:53:47 PDT 
Marked test expectations to speed up EWS https://trac.webkit.org/changeset/283804/webkit
Comment 4 ayumi_kojima 2021-10-08 08:54:27 PDT 
From the crash log and test name, Bug 231255 might be related.
Comment 5 ayumi_kojima 2021-10-08 08:57:29 PDT 
I was not able to reproduce the crash locally on iOS 15 sim using run-webkit-tests --force --iterations 50 --exit-after-n-crashes-or-timeouts 1 http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive.html --ios-simulator

The test failed instead.

Diff:

--- /Volumes/Data/builds/iOS/BuildToTest/layout-test-results/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt
+++ /Volumes/Data/builds/iOS/BuildToTest/layout-test-results/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-actual.txt
@@ -12,3 +12,4 @@
 Attribution trigger data: 12
 Attribution priority: 0
 Attribution earliest time to send: Within 24-48 hours
+Application bundle identifier: org.webkit.WebKitTestRunnerApp
Comment 6 ayumi_kojima 2021-10-08 09:01:26 PDT 
This change https://trac.webkit.org/changeset/283316/webkit includes "setPrivateClickMeasurementAppBundleIDForTesting". Might be related.
Comment 7 John Wilander 2021-10-25 16:41:26 PDT 
Fixed in: https://trac.webkit.org/changeset/284846/webkit
Reverted test expectation in: https://trac.webkit.org/changeset/284848/webkit
Comment 8 John Wilander 2021-10-25 17:14:15 PDT 
We may need another test fix for layout test that use <!-- webkit-test-runner [ enableInAppBrowserPrivacy=true applicationBundleIdentifier=inAppBrowserPrivacyTestIdentifier isAppBoundWebView=true ] -->

_clearApplicationBundleIdentifierTestingOverride() needs to reset the ID in the network process. I've asked Kate to have a look.