Bug 231428 - Merge optimizations to AudioParamTimeline::hasValues() from Blink
Summary: Merge optimizations to AudioParamTimeline::hasValues() from Blink
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://github.com/web-platform-tests...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-08 07:29 PDT by Chris Dumez
Modified: 2021-10-08 12:30 PDT (History)
10 users (show)

See Also:

Attachments
WIP Patch (16.58 KB, patch)
2021-10-08 07:29 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (20.68 KB, patch)
2021-10-08 07:59 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (20.68 KB, patch)
2021-10-08 08:27 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (20.68 KB, patch)
2021-10-08 08:50 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-10-08 07:29:06 PDT 
Merge optimizations to AudioParamTimeline::hasValues() from Blink.
Comment 1 Chris Dumez 2021-10-08 07:29:38 PDT 
Created attachment 440606 [details]
WIP Patch
Comment 2 EWS Watchlist 2021-10-08 07:30:40 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 Chris Dumez 2021-10-08 07:59:16 PDT 
Created attachment 440613 [details]
Patch
Comment 4 Chris Dumez 2021-10-08 08:27:00 PDT 
Created attachment 440617 [details]
Patch
Comment 5 Eric Carlson 2021-10-08 08:46:22 PDT 
Comment on attachment 440617 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440617&action=review

r=me once the bots are happy

> Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp:1014
> +    // The first event starts after the end of this rendering quantum so no automation is needed.

This should be after the `if (...` or should be reworded, e.g. "If the first event starts ..."
Comment 6 Chris Dumez 2021-10-08 08:50:41 PDT 
Created attachment 440621 [details]
Patch
Comment 7 EWS 2021-10-08 12:29:59 PDT 
Committed r283825 (242712@main): <https://commits.webkit.org/242712@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440621 [details].
Comment 8 Radar WebKit Bug Importer 2021-10-08 12:30:19 PDT 
<rdar://problem/84038739>