Bug 231417 - Refactor shouldAutofocus to only call trivial Document getters
Summary: Refactor shouldAutofocus to only call trivial Document getters
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-08 03:48 PDT by youenn fablet
Modified: 2021-10-15 03:49 PDT (History)
11 users (show)

See Also:

Attachments
Patch (6.85 KB, patch)
2021-10-08 04:07 PDT, youenn fablet 		rniwa: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-10-08 03:48:26 PDT 
Refactor shouldAutofocus to only call trivial Document getters
Comment 1 youenn fablet 2021-10-08 04:07:40 PDT 
Created attachment 440590 [details]
Patch
Comment 2 Ryosuke Niwa 2021-10-09 01:23:18 PDT 
Comment on attachment 440590 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440590&action=review

> Source/WebCore/html/HTMLFormControlElement.cpp:210
>      auto& document = element.document();

We really need to store this in Ref. r- because of this.
Comment 3 Radar WebKit Bug Importer 2021-10-15 03:49:16 PDT 
<rdar://problem/84296162>