Minor refactoring to use ScrollUpdate in more places

[Simon Fraser (smfr)]

Minor refactoring to use ScrollUpdate in more places

[Simon Fraser (smfr)]

Created attachment 440544 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 440544 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440544&action=review

> Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:263
> +        auto scrollUpdate = ScrollUpdate { scrollingNodeID, scrollPosition, { }, ScrollingLayerPositionAction::Set };

Why not ScrollUpdate scrollUpdate(scrollingNodeID, scrollPosition, { }, ScrollingLayerPositionAction::Set);?

Or even applyScrollUpdate(ScrollUpdate(scrollingNodeID, scrollPosition, { }, ScrollingLayerPositionAction::Set), ScrollType::Programmatic);?

> Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:309
> +        applyScrollPositionUpdate(WTFMove(update), ScrollType::User);

Cool.

> Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.h:105
> +struct ScrollUpdate {

If you're going to move this, why not move it into its own file?

[EWS]

Committed r283761 (242681@main): <https://commits.webkit.org/242681@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440544 [details].

[Radar WebKit Bug Importer]

<rdar://problem/84007408>