Bug 231370 - Do not check for firstLineStyle while constructing RenderText
Summary: Do not check for firstLineStyle while constructing RenderText
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-07 10:16 PDT by zalan
Modified: 2021-10-07 16:33 PDT (History)
11 users (show)

See Also:

Attachments
Patch (8.32 KB, patch)
2021-10-07 10:32 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (9.35 KB, patch)
2021-10-07 15:01 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-10-07 10:16:19 PDT 
first line style computation expects the renderer to be fully attached to the tree.
Comment 1 zalan 2021-10-07 10:29:19 PDT 
<rdar://83973189>
Comment 2 zalan 2021-10-07 10:32:46 PDT 
Created attachment 440511 [details]
Patch
Comment 3 Antti Koivisto 2021-10-07 10:35:42 PDT 
Comment on attachment 440511 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440511&action=review

> Source/WebCore/rendering/RenderText.cpp:1432
>      // FIXME: All these checks should be more fine-grained at the inline item level.

I guess this FIXME is still relevant?
Comment 4 zalan 2021-10-07 10:36:47 PDT 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 440511 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=440511&action=review
> 
> > Source/WebCore/rendering/RenderText.cpp:1432
> >      // FIXME: All these checks should be more fine-grained at the inline item level.
> 
> I guess this FIXME is still relevant?
yeah for the rest of the content it still is.
Comment 5 zalan 2021-10-07 15:01:59 PDT 
Created attachment 440541 [details]
Patch
Comment 6 EWS 2021-10-07 16:25:13 PDT 
Committed r283754 (242675@main): <https://commits.webkit.org/242675@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440541 [details].
Comment 7 Myles C. Maxfield 2021-10-07 16:31:05 PDT 
Committed r283755 (242676@main): <https://commits.webkit.org/242676@main>
Comment 8 Myles C. Maxfield 2021-10-07 16:32:29 PDT 
(In reply to Myles C. Maxfield from comment #7)
> Committed r283755 (242676@main): <https://commits.webkit.org/242676@main>

What? So confused.
Comment 9 Myles C. Maxfield 2021-10-07 16:33:49 PDT 
To anyone following along: `webkit-patch` messed up, and accidentally thought my patch was this one.

The comment above in https://bugs.webkit.org/show_bug.cgi?id=231370#c7 is bogus, please ignore.