Bug 231363 - [LFC][Integration] Use optimized InlineContent::boxesForRect for hit testing
Summary: [LFC][Integration] Use optimized InlineContent::boxesForRect for hit testing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-07 09:17 PDT by Antti Koivisto
Modified: 2021-10-08 03:22 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.63 KB, patch)
2021-10-07 09:23 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-10-07 09:17:21 PDT
faster hit testing
Comment 1 Antti Koivisto 2021-10-07 09:23:35 PDT
Created attachment 440504 [details]
Patch
Comment 2 EWS 2021-10-07 11:32:56 PDT
Committed r283726 (242650@main): <https://commits.webkit.org/242650@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440504 [details].
Comment 3 Radar WebKit Bug Importer 2021-10-07 11:33:18 PDT
<rdar://problem/83991388>
Comment 4 Darin Adler 2021-10-07 11:38:23 PDT
Is IteratorRange itself not reversible? Can we make it reversible?
Comment 5 Antti Koivisto 2021-10-07 12:15:25 PDT
(In reply to Darin Adler from comment #4)
> Is IteratorRange itself not reversible? Can we make it reversible?

It is not and it would be nice if it was. Reversibility depends on the iterator capabilities so a generic reversible version is probably slightly trickier.
Comment 6 Darin Adler 2021-10-07 12:31:53 PDT
(In reply to Antti Koivisto from comment #5)
> It is not and it would be nice if it was. Reversibility depends on the
> iterator capabilities so a generic reversible version is probably slightly
> trickier.

One idea is to specialize it so it’s reversible when the iterators are pointers. Over time could use better template meta programming to make it reversible in even more cases.
Comment 7 Antti Koivisto 2021-10-08 03:22:15 PDT
Turns out it wasn't difficult at all, bug 231415.