Bug 23134 - Safari 3.2.1 used by bisect-builds tool crashes during testing builds earlier than r37348
Summary: Safari 3.2.1 used by bisect-builds tool crashes during testing builds earlier...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-06 06:28 PST by Robert Blaut
Modified: 2009-01-11 01:43 PST (History)
2 users (show)

See Also:

Attachments
crash log (25.79 KB, text/plain)
2009-01-06 06:28 PST, Robert Blaut 		no flags Details
fix for the crash bug (1.82 KB, patch)
2009-01-06 14:26 PST, Robert Blaut 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Blaut 2009-01-06 06:28:32 PST 
The crash bug is visible with Safari 3.2.1 installed and with build older than r37348. 

So I assume changeset <http://trac.webkit.org/changeset/37348> is problematic.

Crash log attached.
Comment 1 Robert Blaut 2009-01-06 06:28:53 PST 
Created attachment 26459 [details]
crash log
Comment 2 Alexey Proskuryakov 2009-01-06 11:52:37 PST 
Sounds like a WONTFIX to me - certainly we can't preserve compatibility forever?
Comment 3 Robert Blaut 2009-01-06 14:25:34 PST 
(In reply to comment #2)
> Sounds like a WONTFIX to me - certainly we can't preserve compatibility
> forever?
> 

So we should prevent bisect-builds from running incompatible builds :)
Comment 4 Robert Blaut 2009-01-06 14:26:18 PST 
Created attachment 26475 [details]
fix for the crash bug
Comment 5 Eric Seidel (no email) 2009-01-06 15:36:42 PST 
Comment on attachment 26475 [details]
fix for the crash bug

Looks fine.  Seems like we should be using some sub routines for this sort of thing, instead of copy paste.
Comment 6 Alexey Proskuryakov 2009-01-11 01:43:29 PST 
Committed revision 39788.