WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
231331
[JSC] Temporal tweaks to pass more test262 tests
https://bugs.webkit.org/show_bug.cgi?id=231331
Summary
[JSC] Temporal tweaks to pass more test262 tests
Philip Chimento
Reported
2021-10-06 14:24:05 PDT
[JSC] Temporal tweaks to pass more test262 tests
Attachments
Patch
(20.94 KB, patch)
2021-10-06 14:33 PDT
,
Philip Chimento
no flags
Details
Formatted Diff
Diff
Patch
(28.60 KB, patch)
2021-10-06 15:22 PDT
,
Philip Chimento
no flags
Details
Formatted Diff
Diff
Patch
(28.66 KB, patch)
2021-10-06 15:55 PDT
,
Philip Chimento
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Philip Chimento
Comment 1
2021-10-06 14:33:22 PDT
Created
attachment 440438
[details]
Patch
Philip Chimento
Comment 2
2021-10-06 15:22:52 PDT
Created
attachment 440443
[details]
Patch
Yusuke Suzuki
Comment 3
2021-10-06 15:47:24 PDT
Comment on
attachment 440443
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=440443&action=review
Quick comment
> Source/JavaScriptCore/runtime/TemporalObject.h:67 > +//
https://tc39.es/proposal-temporal/#table-temporal-temporaldurationlike-properties
> +static constexpr TemporalUnit temporalUnitsInTableOrder[numberOfTemporalUnits] = { > + TemporalUnit::Day, > + TemporalUnit::Hour, > + TemporalUnit::Microsecond, > + TemporalUnit::Millisecond, > + TemporalUnit::Minute, > + TemporalUnit::Month, > + TemporalUnit::Nanosecond, > + TemporalUnit::Second, > + TemporalUnit::Week, > + TemporalUnit::Year, > +};
Let's put the array content to cpp file to avoid materializing the same constant array multiple times. This will enlarge binary size.
Philip Chimento
Comment 4
2021-10-06 15:55:37 PDT
Created
attachment 440451
[details]
Patch
Yusuke Suzuki
Comment 5
2021-10-06 17:22:34 PDT
Comment on
attachment 440451
[details]
Patch r=me
EWS
Comment 6
2021-10-07 04:27:51 PDT
Committed
r283705
(
242631@main
): <
https://commits.webkit.org/242631@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 440451
[details]
.
Radar WebKit Bug Importer
Comment 7
2021-10-07 04:28:19 PDT
<
rdar://problem/83975733
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug