Bug 231318 – Remove "using namespace XPath;" from XPathGrammar.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Remove "using namespace XPath;" from XPathGrammar.cpp

[Alex Christensen]

Created attachment 440408 [details]
Patch

[Darin Adler]

Oh, got it. Didn’t know we had checked in the yacc output! Sorry for trouble I caused while "helping".

[Alex Christensen]

Created attachment 440422 [details]
Patch

[Darin Adler]

Comment on attachment 440422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440422&action=review

> Source/WebCore/xml/XPathGrammar.cpp:-2160
> -  IGNORE_CLANG_WARNINGS_BEGIN("unreachable-code")
>    if (/*CONSTCOND*/ 0)
>       goto yyerrorlab;
> -  IGNORE_CLANG_WARNINGS_END

I think we need to re-add this change? Since it’s a WebKit-specific macro, it’s unlikely this was generated by Bison.

[Alex Christensen]

Created attachment 440429 [details]
Patch

[Alex Christensen]

Created attachment 440430 [details]
Patch

[Darin Adler]

Comment on attachment 440430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440430&action=review

> Source/WebCore/ChangeLog:9
> +        I did this by editing XPathGrammar.y and re-running bison.
> +        We have the output of bison checked in to our repo to not have bison as a build dependency of WebKit.

Maybe we should record that "ignore warnings" step somewhere

[Alex Christensen]

I'm not sure if the ignore warnings step is still needed.  It seems to have built fine without it.

[Darin Adler]

(In reply to Alex Christensen from comment #8)
> I'm not sure if the ignore warnings step is still needed.  It seems to have
> built fine without it.

Could use git to research when it was done, by who, to see if that makes logical sense.

[Alex Christensen]

Apparently I added the original pragma that ignored that warning in https://trac.webkit.org/changeset/209883/webkit and I don't remember why.  Perhaps it was to make EWS green.  EWS is green now so I don't think it's needed any more.

[Radar WebKit Bug Importer]

<rdar://problem/84210320>

[EWS]

commit-queue failed to commit attachment 440430 [details] to WebKit repository. To retry, please set cq+ flag again.

[Alex Christensen]

I used svn to allow tabs rather than rewrite the generated source.
http://trac.webkit.org/r284420