Bug 231290 - Removing <dialog> from document should reset m_isModal flag
Summary: Removing <dialog> from document should reset m_isModal flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks: dialog-element
  Show dependency tree / graph
 
Reported: 2021-10-06 07:42 PDT by Tim Nguyen (:ntim)
Modified: 2021-10-06 10:29 PDT (History)
7 users (show)

See Also:

Attachments
Patch (8.16 KB, patch)
2021-10-06 07:49 PDT, Tim Nguyen (:ntim) 		zalan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2021-10-06 07:42:38 PDT 
m_isModal triggers the :-internal-modal-dialog pseudo class, which changes position from absolute to fixed.

When removing a modal <dialog> from the document, it is also removed from the top layer, it makes sense to reset the modal dialog flag as well as a result.
Comment 1 Tim Nguyen (:ntim) 2021-10-06 07:49:59 PDT 
Created attachment 440366 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-10-06 08:29:34 PDT 
<rdar://problem/83934967>
Comment 3 Tim Nguyen (:ntim) 2021-10-06 10:29:52 PDT 
Committed r283631 (242582@main): <https://commits.webkit.org/242582@main>