Bug 23126 – Add DRT API to retrieve number of active animations from AnimationController

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Pierre-Olivier Latour]

We need a DRT API to retrieve number of active animations from AnimationController: we have some failure cases where the AnimationController is running while it shouldn't and we should be able to have regression tests for them.

[Pierre-Olivier Latour]

Created attachment 26481 [details]
Patch v1

[Darin Adler]

Comment on attachment 26481 [details]
Patch v1

> +        RefPtr<CompositeAnimation> compAnim = it->second;
> +        count += compAnim->numberOfActiveAnimations();

This will unnecessarily churn the reference count of the animation. You should either use a raw pointer for the local variable, or just use it->second directly.

r=me

[Pierre-Olivier Latour]

(including Darin's recommended change)

Sending        LayoutTests/ChangeLog
Adding         LayoutTests/animations/animation-controller-drt-api-expected.txt
Adding         LayoutTests/animations/animation-controller-drt-api.html
Sending        LayoutTests/platform/win/Skipped
Sending        WebCore/ChangeLog
Sending        WebCore/WebCore.base.exp
Sending        WebCore/page/animation/AnimationController.cpp
Sending        WebCore/page/animation/AnimationController.h
Sending        WebCore/page/animation/CompositeAnimation.cpp
Sending        WebCore/page/animation/CompositeAnimation.h
Sending        WebKit/mac/ChangeLog
Sending        WebKit/mac/WebView/WebFrame.mm
Sending        WebKit/mac/WebView/WebFramePrivate.h
Sending        WebKitTools/ChangeLog
Sending        WebKitTools/DumpRenderTree/LayoutTestController.cpp
Sending        WebKitTools/DumpRenderTree/LayoutTestController.h
Sending        WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm
Sending        WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp
Transmitting file data ..................
Committed revision 39669.