The difference is the existence of last s character. I believe ENABLE_EXPERIMENTAL_FEATURE is the typo, but I don't know the history well so it can be the left over of something. Anyway, ENABLE(EXPERIMENTAL_FEATURE) won't be true with current toolchain. It will be renamed to ENABLE(EXPERIMENTAL_FEATURES) or be deleted from the codebase if it won't be used.
Do you mean the EXPERIMENTAL_FEATURE in the tests inside Source/WebKit/Scripts/webkit? because that is actually a unnamed single mock feature for tests, not the same as ENABLE(EXPERIMENTAL_FEATURES). But I agree that it should have a less bizarrely ambiguous name, if that is the one you are talking about (it's the only one I can find). Wenson suggested `MY_FEATURE` (you could also imagine `FEATURE_FOR_TESTING` or something).
(In reply to Tim Horton from comment #1) > Do you mean the EXPERIMENTAL_FEATURE in the tests inside > Source/WebKit/Scripts/webkit? Correct. > because that is actually a unnamed single mock > feature for tests, not the same as ENABLE(EXPERIMENTAL_FEATURES). But I > agree that it should have a less bizarrely ambiguous name, if that is the > one you are talking about (it's the only one I can find). Wenson suggested > `MY_FEATURE` (you could also imagine `FEATURE_FOR_TESTING` or something). Make sense. I like the `FEATURE_FOR_TESTING` for replacement. Also it should be better to change the title of this bug. How about "Change the confusing feature name for testing purpose"?
(In reply to Basuke Suzuki from comment #2) > (In reply to Tim Horton from comment #1) > > Do you mean the EXPERIMENTAL_FEATURE in the tests inside > > Source/WebKit/Scripts/webkit? > > Correct. > > > because that is actually a unnamed single mock > > feature for tests, not the same as ENABLE(EXPERIMENTAL_FEATURES). But I > > agree that it should have a less bizarrely ambiguous name, if that is the > > one you are talking about (it's the only one I can find). Wenson suggested > > `MY_FEATURE` (you could also imagine `FEATURE_FOR_TESTING` or something). > > Make sense. I like the `FEATURE_FOR_TESTING` for replacement. Also it should > be better to change the title of this bug. How about "Change the confusing > feature name for testing purpose"? Sounds good to me!
Created attachment 440476 [details] PATCH
Committed r283702 (242628@main): <https://commits.webkit.org/242628@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440476 [details].
<rdar://problem/83970509>