WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
231254
Do daily activity in AdAttributionDaemon based off of when the xpc activity happens
https://bugs.webkit.org/show_bug.cgi?id=231254
Summary
Do daily activity in AdAttributionDaemon based off of when the xpc activity h...
Alex Christensen
Reported
2021-10-05 14:20:17 PDT
Do daily activity in AdAttributionDaemon based off of when the xpc activity happens
Attachments
Patch
(9.17 KB, patch)
2021-10-05 14:21 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(9.17 KB, patch)
2021-10-05 17:03 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2021-10-05 14:21:51 PDT
Created
attachment 440267
[details]
Patch
Kate Cheney
Comment 2
2021-10-05 16:08:38 PDT
Comment on
attachment 440267
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=440267&action=review
> Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDaemonClient.h:41 > + bool runningInDaemon() const final { return false; }
Shouldn't this be true?
Alex Christensen
Comment 3
2021-10-05 17:02:37 PDT
Comment on
attachment 440267
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=440267&action=review
>> Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDaemonClient.h:41 >> + bool runningInDaemon() const final { return false; } > > Shouldn't this be true?
yes
Alex Christensen
Comment 4
2021-10-05 17:03:44 PDT
Created
attachment 440302
[details]
Patch
Kate Cheney
Comment 5
2021-10-05 17:07:52 PDT
Comment on
attachment 440302
[details]
Patch r=me
EWS
Comment 6
2021-10-05 18:16:34 PDT
Committed
r283595
(
242550@main
): <
https://commits.webkit.org/242550@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 440302
[details]
.
Radar WebKit Bug Importer
Comment 7
2021-10-05 18:17:18 PDT
<
rdar://problem/83914029
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug