Bug 231254 - Do daily activity in AdAttributionDaemon based off of when the xpc activity happens
Summary: Do daily activity in AdAttributionDaemon based off of when the xpc activity h...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-05 14:20 PDT by Alex Christensen
Modified: 2021-10-05 18:17 PDT (History)
2 users (show)

See Also:

Attachments
Patch (9.17 KB, patch)
2021-10-05 14:21 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (9.17 KB, patch)
2021-10-05 17:03 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-10-05 14:20:17 PDT 
Do daily activity in AdAttributionDaemon based off of when the xpc activity happens
Comment 1 Alex Christensen 2021-10-05 14:21:51 PDT 
Created attachment 440267 [details]
Patch
Comment 2 Kate Cheney 2021-10-05 16:08:38 PDT 
Comment on attachment 440267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440267&action=review

> Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDaemonClient.h:41
> +    bool runningInDaemon() const final { return false; }

Shouldn't this be true?
Comment 3 Alex Christensen 2021-10-05 17:02:37 PDT 
Comment on attachment 440267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440267&action=review

>> Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDaemonClient.h:41
>> +    bool runningInDaemon() const final { return false; }
> 
> Shouldn't this be true?

yes
Comment 4 Alex Christensen 2021-10-05 17:03:44 PDT 
Created attachment 440302 [details]
Patch
Comment 5 Kate Cheney 2021-10-05 17:07:52 PDT 
Comment on attachment 440302 [details]
Patch

r=me
Comment 6 EWS 2021-10-05 18:16:34 PDT 
Committed r283595 (242550@main): <https://commits.webkit.org/242550@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440302 [details].
Comment 7 Radar WebKit Bug Importer 2021-10-05 18:17:18 PDT 
<rdar://problem/83914029>