Bug 231251 – Add back RetainPtrARC and TypeCastsCocoaARC tests to TestWTF

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[David Kilzer (:ddkilzer)]

Add back RetainPtrARC and TypeCastsCocoaARC tests to TestWTF.

They were removed for:

    Bug 230406: WTF::RetainPtr<> allows assignment of two pointer types that are not assignable

They were removed to make the bots green again:

    Bug 231172: REGRESSION (r283476): [ iOS macOS Debug ] TestWTF failures in RetainPtrARC and TypeCastsCocoaARC

[Radar WebKit Bug Importer]

<rdar://problem/83902809>

[David Kilzer (:ddkilzer)]

See test failures here:

<https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&test=TestWTF.TypeCastsCocoaARC.dynamic_objc_cast_RetainPtr&test=TestWTF.TypeCastsCocoaARC.dynamic_objc_cast&test=TestWTF.TypeCastsCocoaARC.checked_objc_cast&test=TestWTF.TypeCastsCocoaARC.bridge_id_cast&test=TestWTF.RetainPtrARC.RetainPtrNS&test=TestWTF.RetainPtrARC.AdoptNS>

[David Kilzer (:ddkilzer)]

Created attachment 440455 [details]
Patch v1

[Darin Adler]

Comment on attachment 440455 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=440455&action=review

Nice solution.

> Source/WTF/ChangeLog:12
> +        * wtf/cocoa/TypeCastsCocoa.h:
> +        (checked_objc_castArc):
> +        - Change `checked_objc_castARC` to `checked_objc_castArc` to
> +          match `adoptNSArc`.

Nice to match, but not sure why Chris decided to turn ARC into a word.

> Tools/TestWebKitAPI/Tests/WTF/cocoa/TypeCastsCocoa.mm:38
> +#define TEST_WTF_BEGIN_AUTORELEASEPOOL @autoreleasepool {

I suggest a name like: BEGIN_AUTORELEASEPOOL_FOR_ARC_DEBUG

I understand the concept of using "WTF" to avoid conflicts, and "TEST", but I don’t think either are needed in practice.

[David Kilzer (:ddkilzer)]

Comment on attachment 440455 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=440455&action=review

>> Source/WTF/ChangeLog:12
>> +          match `adoptNSArc`.
> 
> Nice to match, but not sure why Chris decided to turn ARC into a word.

I'll revert this change for the final patch.

>> Tools/TestWebKitAPI/Tests/WTF/cocoa/TypeCastsCocoa.mm:38
>> +#define TEST_WTF_BEGIN_AUTORELEASEPOOL @autoreleasepool {
> 
> I suggest a name like: BEGIN_AUTORELEASEPOOL_FOR_ARC_DEBUG
> 
> I understand the concept of using "WTF" to avoid conflicts, and "TEST", but I don’t think either are needed in practice.

Will do.

[David Kilzer (:ddkilzer)]

Created attachment 440462 [details]
Patch for landing

[EWS]

Committed r283712 (242638@main): <https://commits.webkit.org/242638@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440462 [details].