Bug 231250 - FileSystemHandle should be ContextDestructionObserver
Summary: FileSystemHandle should be ContextDestructionObserver
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks: 231706
  Show dependency treegraph
 
Reported: 2021-10-05 13:51 PDT by Sihui Liu
Modified: 2021-10-26 14:42 PDT (History)
6 users (show)

See Also:


Attachments
Patch (30.54 KB, patch)
2021-10-25 10:32 PDT, Sihui Liu
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (30.70 KB, patch)
2021-10-25 10:38 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff
Patch for landing (30.72 KB, patch)
2021-10-26 14:11 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2021-10-05 13:51:00 PDT
Same as FileSystemSyncAccessHandle.
Comment 1 Radar WebKit Bug Importer 2021-10-12 13:51:18 PDT
<rdar://problem/84164797>
Comment 2 Sihui Liu 2021-10-25 10:32:24 PDT
Created attachment 442383 [details]
Patch
Comment 3 Sihui Liu 2021-10-25 10:38:22 PDT
Created attachment 442384 [details]
Patch
Comment 4 youenn fablet 2021-10-26 02:03:02 PDT
Comment on attachment 442384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442384&action=review

> Source/WebCore/Modules/filesystemaccess/FileSystemHandle.h:57
> +    FileSystemHandle(ScriptExecutionContext*, Kind, String&& name, FileSystemHandleIdentifier, Ref<FileSystemStorageConnection>&&);

We usually go with ScriptExecutionContext&

> Source/WebCore/Modules/storage/StorageManager.cpp:122
> +        auto* context = weakNavgiator ? weakNavgiator->scriptExecutionContext() : nullptr;

s/weakNavgiator/weakNavigator
Comment 5 Sihui Liu 2021-10-26 14:11:38 PDT
Created attachment 442528 [details]
Patch for landing
Comment 6 EWS 2021-10-26 14:42:15 PDT
Committed r284900 (243577@main): <https://commits.webkit.org/243577@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442528 [details].