Bug 231238 - Share macOS code between ScrollAnimator::handleWheelEvent() and ScrollingEffectsController::handleWheelEvent()
Summary: Share macOS code between ScrollAnimator::handleWheelEvent() and ScrollingEffe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
: 234495 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-10-05 10:14 PDT by Simon Fraser (smfr)
Modified: 2021-12-23 09:20 PST (History)
13 users (show)

See Also:

Attachments
Patch (21.48 KB, patch)
2021-12-22 16:32 PST, Simon Fraser (smfr) 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-10-05 10:14:36 PDT 
There's duplicate but slightly different code here and it needs to be cleaned up. This code is hit for some non-accelerated cases like list box scrolling.
Comment 1 Radar WebKit Bug Importer 2021-10-12 10:15:29 PDT 
<rdar://problem/84153262>
Comment 2 Simon Fraser (smfr) 2021-12-20 19:59:00 PST 
*** Bug 234495 has been marked as a duplicate of this bug. ***
Comment 3 Simon Fraser (smfr) 2021-12-22 16:32:00 PST 
Created attachment 447841 [details]
Patch
Comment 4 Wenson Hsieh 2021-12-22 16:46:14 PST 
Comment on attachment 447841 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447841&action=review

r=mews

> Source/WebCore/ChangeLog:18
> +        The ScrollAnimatorMac::handleWheelEvent() override now simply class into the base class,

"class into" => "calls into"
Comment 5 Simon Fraser (smfr) 2021-12-23 09:20:20 PST 
https://trac.webkit.org/changeset/287397/webkit