Bug 231230 - Simplify BaseAudioSharedUnit client management
Summary: Simplify BaseAudioSharedUnit client management
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-05 06:53 PDT by youenn fablet
Modified: 2021-10-06 03:14 PDT (History)
10 users (show)

See Also:

Attachments
Patch (7.40 KB, patch)
2021-10-05 07:04 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (6.17 KB, patch)
2021-10-05 07:37 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (6.16 KB, patch)
2021-10-06 00:20 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-10-05 06:53:03 PDT 
<rdar://83884131>
Comment 1 youenn fablet 2021-10-05 07:04:24 PDT 
Created attachment 440209 [details]
Patch
Comment 2 youenn fablet 2021-10-05 07:37:58 PDT 
Created attachment 440210 [details]
Patch
Comment 3 Eric Carlson 2021-10-05 09:34:03 PDT 
Comment on attachment 440210 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440210&action=review

> Source/WebCore/ChangeLog:14
> +        Instead of doing that, we now exclusively access m_clients from main thread, it does not require a lokc anymore.

s/lokc/lock/
Comment 4 youenn fablet 2021-10-06 00:20:02 PDT 
Created attachment 440339 [details]
Patch for landing
Comment 5 EWS 2021-10-06 03:14:47 PDT 
Committed r283611 (242563@main): <https://commits.webkit.org/242563@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440339 [details].