CPA perf is too slow, esp. when compared to pure array
Created attachment 26444 [details] Devirtualise byte array logic devirtualisation-fu
Created attachment 26445 [details] Fixed issues pointed out by mark Minor updates
Comment on attachment 26445 [details] Fixed issues pointed out by mark If bdash is happy with the style, then I'm happy with the logic.
Committing to http://svn.webkit.org/repository/webkit/trunk ... C WebCore/bindings/js/JSImageDataCustom.cpp => JavaScriptCore/runtime/ByteArray.h R WebCore/bindings/js/JSCanvasPixelArrayCustom.h => JavaScriptCore/runtime/ByteArray.cpp D WebCore/html/CanvasPixelArray.cpp D WebCore/html/CanvasPixelArray.h D WebCore/html/CanvasPixelArray.idl M JavaScriptCore/ChangeLog M JavaScriptCore/GNUmakefile.am M JavaScriptCore/JavaScriptCore.exp M JavaScriptCore/JavaScriptCore.pri M JavaScriptCore/JavaScriptCore.scons M JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj M JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj M JavaScriptCore/interpreter/Interpreter.cpp M JavaScriptCore/interpreter/Interpreter.h A JavaScriptCore/runtime/JSByteArray.cpp A JavaScriptCore/runtime/JSByteArray.h M WebCore/ChangeLog M WebCore/DerivedSources.make A WebCore/ForwardingHeaders/runtime/ByteArray.h A WebCore/ForwardingHeaders/runtime/JSByteArray.h M WebCore/GNUmakefile.am M WebCore/WebCore.pro M WebCore/WebCore.scons M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/WebCore.xcodeproj/project.pbxproj M WebCore/WebCoreSources.bkl M WebCore/bindings/js/JSImageDataCustom.cpp M WebCore/html/CanvasRenderingContext2D.cpp M WebCore/html/ImageData.cpp M WebCore/html/ImageData.h M WebCore/html/ImageData.idl M WebCore/platform/graphics/cg/ImageBufferCG.cpp Committed r39625
Is it appropriate for WebCore to be using this JSC runtime/ class? I don't know the rules, but this moved from using a WebCore type (CanvasPixelArray), to the new ByteArray JSC class. It seems like it would be preferred to have the type in WebCore... Thanks
This is necessary to achieve acceptable performance, pulling bytearray into webcore would result in a cyclic dependency. (In reply to comment #5) > Is it appropriate for WebCore to be using this JSC runtime/ class? I don't > know the rules, but this moved from using a WebCore type (CanvasPixelArray), to > the new ByteArray JSC class. It seems like it would be preferred to have the > type in WebCore... > > Thanks >
It may be possible to pull bytearray into WTF actually, which seems betterer