RESOLVED FIXED 231221
Replace document.topDocument().securityOrigin() with document.topOrigin() 
https://bugs.webkit.org/show_bug.cgi?id=231221
Summary Replace document.topDocument().securityOrigin() with document.topOrigin()
Tim Nguyen (:ntim)
Reported 2021-10-05 02:07:40 PDT
Document::topOrigin() is defined as: SecurityOrigin& topOrigin() const final { return topDocument().securityOrigin(); }
Attachments
Patch (6.84 KB, patch)
2021-10-05 02:26 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Patch (7.62 KB, patch)
2021-10-05 03:01 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Nguyen (:ntim)
Comment 1 2021-10-05 02:26:11 PDT
Created attachment 440185 [details] Patch
youenn fablet
Comment 2 2021-10-05 02:29:28 PDT
Comment on attachment 440185 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440185&action=review > Source/WebCore/dom/DocumentStorageAccess.cpp:92 > + auto& topSecurityOrigin = m_document.topOrigin(); topSecurityOrigin is only used once, can we remove this variable? > Source/WebCore/dom/DocumentStorageAccess.cpp:162 > + auto& topSecurityOrigin = m_document.topOrigin(); Ditto for both topSecurityOrigin and topDocument
Tim Nguyen (:ntim)
Comment 3 2021-10-05 03:01:26 PDT
Created attachment 440191 [details] Patch
EWS
Comment 4 2021-10-05 04:00:04 PDT
Committed r283544 (242509@main): <https://commits.webkit.org/242509@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440191 [details].
Radar WebKit Bug Importer
Comment 5 2021-10-05 04:01:21 PDT
<rdar://problem/83880206>
Note You need to log in before you can comment on or make changes to this bug.