Bug 23122 - platform/animation/Animation.cpp includes RenderStyle.h: bad dependency
Summary: platform/animation/Animation.cpp includes RenderStyle.h: bad dependency
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Chris Marrin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-05 13:33 PST by Simon Fraser (smfr)
Modified: 2009-01-07 17:38 PST (History)
0 users

See Also:

Attachments
patch (12.17 KB, patch)
2009-01-07 16:57 PST, Chris Marrin 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-01-05 13:33:36 PST 
Animation.cpp breaks the platform abstraction by pulling in RenderStyle.h, for initialAnimationDelay() and friends.
Comment 1 Chris Marrin 2009-01-07 16:57:18 PST 
Created attachment 26514 [details]
patch
Comment 2 Eric Seidel (no email) 2009-01-07 16:58:52 PST 
Comment on attachment 26514 [details]
patch

Looks good.
Comment 3 Chris Marrin 2009-01-07 17:38:26 PST 
Sending        WebCore/ChangeLog
Sending        WebCore/css/CSSComputedStyleDeclaration.cpp
Sending        WebCore/css/CSSHelper.h
Sending        WebCore/css/CSSStyleSelector.cpp
Sending        WebCore/platform/animation/Animation.cpp
Sending        WebCore/platform/animation/Animation.h
Sending        WebCore/rendering/style/RenderStyle.h
Transmitting file data .......
Committed revision 39696.