Bug 231211 - Add support for Wasm exceptions in the Air generator
Summary: Add support for Wasm exceptions in the Air generator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on: 234909
Blocks:
  Show dependency tree / graph
 
Reported: 2021-10-04 22:45 PDT by Tadeu Zagallo
Modified: 2022-01-07 19:43 PST (History)
7 users (show)

See Also:

Attachments
WIP (20.24 KB, patch)
2022-01-05 16:14 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
WIP (20.55 KB, patch)
2022-01-05 16:39 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
WIP (31.41 KB, patch)
2022-01-05 18:18 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
WIP (39.07 KB, patch)
2022-01-05 19:03 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
WIP (43.72 KB, patch)
2022-01-06 11:44 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
WIP (46.20 KB, patch)
2022-01-06 12:08 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
WIP (46.66 KB, patch)
2022-01-06 12:48 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
WIP (48.22 KB, patch)
2022-01-06 14:46 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
WIP (49.15 KB, patch)
2022-01-06 16:40 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (69.17 KB, patch)
2022-01-06 22:30 PST, Saam Barati 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch (75.87 KB, patch)
2022-01-07 12:52 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (75.88 KB, patch)
2022-01-07 12:56 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (11) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2021-10-04 22:45:30 PDT 
...
Comment 1 Radar WebKit Bug Importer 2021-10-11 22:46:42 PDT 
<rdar://problem/84132861>
Comment 2 Saam Barati 2022-01-04 13:32:46 PST 
I think ima do this.
Comment 3 Saam Barati 2022-01-05 16:14:46 PST 
Created attachment 448449 [details]
WIP
Comment 4 Saam Barati 2022-01-05 16:39:28 PST 
Created attachment 448453 [details]
WIP
Comment 5 Saam Barati 2022-01-05 18:18:14 PST 
Created attachment 448461 [details]
WIP
Comment 6 Saam Barati 2022-01-05 19:03:45 PST 
Created attachment 448462 [details]
WIP
Comment 7 Saam Barati 2022-01-06 11:44:45 PST 
Created attachment 448516 [details]
WIP
Comment 8 Saam Barati 2022-01-06 12:08:41 PST 
Created attachment 448522 [details]
WIP
Comment 9 Saam Barati 2022-01-06 12:48:53 PST 
Created attachment 448528 [details]
WIP
Comment 10 Saam Barati 2022-01-06 14:46:00 PST 
Created attachment 448538 [details]
WIP

At least one test runs.
Comment 11 Saam Barati 2022-01-06 16:40:11 PST 
Created attachment 448545 [details]
WIP

Patch is ready, just gotta clean some stuff up. But first, gotta fix https://bugs.webkit.org/show_bug.cgi?id=234909
Comment 12 Saam Barati 2022-01-06 22:30:32 PST 
Created attachment 448562 [details]
patch
Comment 13 Saam Barati 2022-01-07 10:41:34 PST 
JSC failure might be x86_64 specific. Looking into it. Doesn't reproduce on my M1 Mac for an arm64 binary
Comment 14 Saam Barati 2022-01-07 12:52:28 PST 
Created attachment 448621 [details]
patch
Comment 15 Saam Barati 2022-01-07 12:56:27 PST 
Created attachment 448622 [details]
patch
Comment 16 EWS 2022-01-07 17:58:14 PST 
Committed r287801 (245854@main): <https://commits.webkit.org/245854@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448622 [details].
Comment 17 Saam Barati 2022-01-07 19:43:16 PST 
fix debug assert in:
https://trac.webkit.org/changeset/287806/webkit