Bug 231203 - Add support for '-webkit-appearance: auto'
Summary: Add support for '-webkit-appearance: auto'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on: 231383
Blocks:
  Show dependency tree / graph
 
Reported: 2021-10-04 18:06 PDT by Aditya Keerthi
Modified: 2021-10-08 18:39 PDT (History)
15 users (show)

See Also:

Attachments
Patch (32.18 KB, patch)
2021-10-04 18:10 PDT, Aditya Keerthi 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (32.53 KB, patch)
2021-10-04 18:53 PDT, Aditya Keerthi 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (35.08 KB, patch)
2021-10-05 12:16 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
Patch (17.39 KB, patch)
2021-10-07 12:15 PDT, Aditya Keerthi 		wenson_hsieh: review+
Details | Formatted Diff | Diff
Patch for landing (17.39 KB, patch)
2021-10-08 15:08 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
Patch for landing (17.40 KB, patch)
2021-10-08 15:13 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Aditya Keerthi 2021-10-04 18:06:42 PDT 
rdar://83696133
Comment 2 Aditya Keerthi 2021-10-04 18:10:36 PDT 
Created attachment 440134 [details]
Patch
Comment 3 Aditya Keerthi 2021-10-04 18:53:39 PDT 
Created attachment 440143 [details]
Patch
Comment 4 Aditya Keerthi 2021-10-05 12:16:37 PDT 
Created attachment 440245 [details]
Patch
Comment 5 Aditya Keerthi 2021-10-07 12:15:31 PDT 
Created attachment 440522 [details]
Patch
Comment 6 Wenson Hsieh 2021-10-08 14:24:54 PDT 
Comment on attachment 440522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440522&action=review

> Source/WebCore/rendering/RenderTheme.cpp:294
> +    auto& element = *elementPtr;

Nit - I think current guidelines (https://lists.webkit.org/pipermail/webkit-dev/2020-September/031386.html) recommend storing this as a `Ref` instead of a raw reference.

> Source/WebCore/rendering/RenderTheme.cpp:300
> +            return PushButtonPart;

Just as an aside — we should consider making these strongly typed `enum class` at some point.
Comment 7 Aditya Keerthi 2021-10-08 15:08:24 PDT 
Created attachment 440680 [details]
Patch for landing
Comment 8 Aditya Keerthi 2021-10-08 15:10:58 PDT 
(In reply to Wenson Hsieh from comment #6)
> Comment on attachment 440522 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=440522&action=review
> 
> > Source/WebCore/rendering/RenderTheme.cpp:294
> > +    auto& element = *elementPtr;
> 
> Nit - I think current guidelines
> (https://lists.webkit.org/pipermail/webkit-dev/2020-September/031386.html)
> recommend storing this as a `Ref` instead of a raw reference.

Done.
 
> > Source/WebCore/rendering/RenderTheme.cpp:300
> > +            return PushButtonPart;
> 
> Just as an aside — we should consider making these strongly typed `enum
> class` at some point.

Filed https://bugs.webkit.org/show_bug.cgi?id=231457 to do this cleanup.
Comment 9 Aditya Keerthi 2021-10-08 15:13:11 PDT 
Created attachment 440681 [details]
Patch for landing
Comment 10 EWS 2021-10-08 18:39:38 PDT 
Committed r283858 (242736@main): <https://commits.webkit.org/242736@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440681 [details].