Bug 231200 - Move handling of AXValue from platform wrapper to AX core code.
Summary: Move handling of AXValue from platform wrapper to AX core code.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-04 17:50 PDT by Andres Gonzalez
Modified: 2021-10-05 11:42 PDT (History)
9 users (show)

See Also:

Attachments
Patch (11.96 KB, patch)
2021-10-04 18:00 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (11.91 KB, patch)
2021-10-05 05:20 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2021-10-04 17:50:02 PDT 
Move handling of AXValue from platform wrapper to AX core code.
Comment 1 Andres Gonzalez 2021-10-04 18:00:41 PDT 
Created attachment 440131 [details]
Patch
Comment 2 chris fleizach 2021-10-04 18:06:36 PDT 
Comment on attachment 440131 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440131&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2297
> +            [] (bool& typedValue) { return [NSNumber numberWithBool:typedValue]; },

You should be able to use boxed values for bool and float
Comment 3 Andres Gonzalez 2021-10-05 05:20:03 PDT 
Created attachment 440202 [details]
Patch
Comment 4 EWS 2021-10-05 11:41:14 PDT 
Committed r283564 (242529@main): <https://commits.webkit.org/242529@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440202 [details].
Comment 5 Radar WebKit Bug Importer 2021-10-05 11:42:22 PDT 
<rdar://problem/83896403>