Bug 231198 - [LFC][IFC] Move tryBreaking*Run logic to standalone functions
Summary: [LFC][IFC] Move tryBreaking*Run logic to standalone functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-04 16:22 PDT by zalan
Modified: 2021-10-05 07:51 PDT (History)
5 users (show)

See Also:

Attachments
Patch (21.62 KB, patch)
2021-10-04 16:27 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-10-04 16:22:40 PDT 
InlineContentBreaker::processOverflowingContentWithText is getting too large
Comment 1 zalan 2021-10-04 16:27:10 PDT 
Created attachment 440120 [details]
Patch
Comment 2 Antti Koivisto 2021-10-05 06:42:24 PDT 
Comment on attachment 440120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440120&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:-367
> -    auto tryBreakingNextOverflowingRuns = [&]() -> std::optional<OverflowingTextContent::BreakingPosition> {

:sadlambda:
Comment 3 zalan 2021-10-05 07:42:43 PDT 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 440120 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=440120&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:-367
> > -    auto tryBreakingNextOverflowingRuns = [&]() -> std::optional<OverflowingTextContent::BreakingPosition> {
> 
> :sadlambda:
:(
Comment 4 EWS 2021-10-05 07:50:05 PDT 
Committed r283549 (242514@main): <https://commits.webkit.org/242514@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440120 [details].
Comment 5 Radar WebKit Bug Importer 2021-10-05 07:51:19 PDT 
<rdar://problem/83885877>