RESOLVED FIXED 231198
[LFC][IFC] Move tryBreaking*Run logic to standalone functions 
https://bugs.webkit.org/show_bug.cgi?id=231198
Summary [LFC][IFC] Move tryBreaking*Run logic to standalone functions
zalan
Reported 2021-10-04 16:22:40 PDT
InlineContentBreaker::processOverflowingContentWithText is getting too large
Attachments
Patch (21.62 KB, patch)
2021-10-04 16:27 PDT, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2021-10-04 16:27:10 PDT
Created attachment 440120 [details] Patch
Antti Koivisto
Comment 2 2021-10-05 06:42:24 PDT
Comment on attachment 440120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440120&action=review > Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:-367 > - auto tryBreakingNextOverflowingRuns = [&]() -> std::optional<OverflowingTextContent::BreakingPosition> { :sadlambda:
zalan
Comment 3 2021-10-05 07:42:43 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 440120 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=440120&action=review > > > Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:-367 > > - auto tryBreakingNextOverflowingRuns = [&]() -> std::optional<OverflowingTextContent::BreakingPosition> { > > :sadlambda: :(
EWS
Comment 4 2021-10-05 07:50:05 PDT
Committed r283549 (242514@main): <https://commits.webkit.org/242514@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440120 [details].
Radar WebKit Bug Importer
Comment 5 2021-10-05 07:51:19 PDT
<rdar://problem/83885877>
Note You need to log in before you can comment on or make changes to this bug.